Re: [RFC} arm architecture board/feature deprecation timeline
- To: "Jeremy J. Peper" <jeremy@jeremypeper.com>, linux-arm-kernel@lists.infradead.org
- Cc: linux-kernel@vger.kernel.org, "Russell King" <linux@armlinux.org.uk>, "Linus Walleij" <linus.walleij@linaro.org>, "Richard Earnshaw" <richard.earnshaw@arm.com>, "Richard Sandiford" <richard.sandiford@arm.com>, "Ramana Radhakrishnan" <ramanara@nvidia.com>, "Nicolas Pitre" <nico@fluxnic.net>, "Krzysztof Kozlowski" <krzk@kernel.org>, "Mark Brown" <broonie@kernel.org>, "Kristoffer Ericson" <kristoffer.ericson@gmail.com>, "Robert Jarzmik" <robert.jarzmik@free.fr>, "Aaro Koskinen" <aaro.koskinen@iki.fi>, "Janusz Krzysztofik" <jmkrzyszt@gmail.com>, "Tony Lindgren" <tony@atomide.com>, Linux-OMAP <linux-omap@vger.kernel.org>, "Nikita Shubin" <nikita.shubin@maquefel.me>, linux-samsung-soc@vger.kernel.org, "Andrew Lunn" <andrew@lunn.ch>, "Sebastian Hesselbarth" <sebastian.hesselbarth@gmail.com>, "Gregory Clement" <gregory.clement@bootlin.com>, debian-arm@lists.debian.org, "Dmitry Torokhov" <dmitry.torokhov@gmail.com>, "Alexandre Torgue" <alexandre.torgue@foss.st.com>
- Subject: Re: [RFC} arm architecture board/feature deprecation timeline
- From: "Arnd Bergmann" <arnd@arndb.de>
- Date: Mon, 19 Aug 2024 16:12:10 +0200
- Message-id: <[🔎] a8c009b5-ada0-4f78-92f7-7a6c5075ccf1@app.fastmail.com>
- In-reply-to: <[🔎] 790bf2c4-2ecf-429c-8e28-ad5807ffed7a@app.fastmail.com>
- References: <2831c5a6-cfbf-4fe0-b51c-0396e5b0aeb7@app.fastmail.com> <3413899.e9J7NaK4W3@earth> <[🔎] 790bf2c4-2ecf-429c-8e28-ad5807ffed7a@app.fastmail.com>
Two small additions:
On Mon, Aug 19, 2024, at 11:17, Arnd Bergmann wrote:
> On Thu, Aug 15, 2024, at 21:53, jeremy@jeremypeper.com wrote:
> I expect that the terastation pro2 is going to be fairly easy to
> convert to DT as there is already support for similar Orion5x
> machines. In this case I would just remove all the Orion5x board
> files and you can add a dts file later on. The bit I'm unsure
> about here is legacy PCI support. I see that the board file enables
> both PCI and PCIe, but I don't know if both are actually used,
> or if everything is on PCIe.
>
> I have some old patches for separating orion legacy PCI from
> PCIe support, as only the latter has a modern driver (shared
> with kirkwood and armadaxp). If you can confirm that the machine
> actually uses PCI, I can dig those out from my backups.
I did find this myself later, the machine does use an on-board
PCI connected SATA controller, which is obviously required to
make the machine useful.
Doing a PCI host bridge driver with DT support correctly is
a lot of work, especially if there is only a single machine
using it. Since this uses the same drivers/ata/sata-mv.c
driver as the other orion/kirkwood machines, I wonder if we
can just pretend that this is a platform device and skip
all of the PCI probing. I think this only needs a few
small changes to the sata-mv.c driver, but it does require
that the PCI bus is left in a known state by the boot loader.
> The WXL machine is going to be more work since there is currently
> no DT support for mv78xx0, but everything except the pin controller
> should at least have a driver since this SoC is somewhere between
> Kirkwood and Dove. Having a hack for the pin controller similar
> to what orion5x has is probably fine, especially if you only
> need to support one machine.
The complication here is that removing the board file would
imply that all of the mv78xx0 code immediately becomes dead
code. I guess the next best idea is to remove the orion5x
and dove board files first and then move bits of plat-orion
that are actually used by the WXL machine into the mv78xx0
directory.
Arnd
Reply to: