Re: [PATCH V2] d-i hd-media support for armhf
On Tue, Sep 30, 2014 at 04:51:46PM -0700, Vagrant Cascadian wrote:
> On 2014-09-30 15:47:13 -0700, Karsten Merker wrote:
> > * Add the "console=" parameter to bootargs only if ${console}
> > is set.
> ...
> > diff --git a/build/boot/arm/bootscr.mainline_common b/build/boot/arm/bootscr.mainline_common
> ...
> > +if test -z "${console}"; then
> > + setenv bootargs "${bootargs} console=${console}"
> > +fi
>
> That looks backwards, it'll only set console= when ${console} is
> empty... possibly overwriting a valid value in bootargs...
Oops - yes, that should be a "test -n".
Regards,
Karsten
--
Gem. Par. 28 Abs. 4 Bundesdatenschutzgesetz widerspreche ich der Nutzung
sowie der Weitergabe meiner personenbezogenen Daten für Zwecke der
Werbung sowie der Markt- oder Meinungsforschung.
Reply to: