Re: Debian patch for PHP on ARM

On Wed, Sep 25, 2013 at 11:00 AM, Lior Kaplan <kaplan@debian.org> wrote:

Hi,

I'm trying to figure if this old patch for PHP in Debian for ARM is still relevant for us. It was added in 2005, but much have changed since then.

I've asked someone who is doing ARM optimization of the PHP code, and his answer is bellow. Would be happy to here you're opinion about this.

The patch:

http://anonscm.debian.org/gitweb/?p=pkg-php/php.git;a=blob;f=debian/patches/044-strtod_arm_fix.patch;h=729f0a11cc688c92ec545d3100fae9eb512376d9;hb=HEAD

Current upstream file (if needed):
http://git.php.net/?p=php-src.git;a=blob;f=Zend/zend_strtod.c;h=d6e5ccf9604a79c19b2c0d3ba3ee6d8a8b377ab7;hb=HEAD

TIA,

Kaplan

---------- Forwarded message ----------
From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Date: Tue, Sep 24, 2013 at 5:06 PM
Subject: Re: Debian patch for PHP on ARM
To: Lior Kaplan <kaplan@debian.org>

On 24 September 2013 17:03, Lior Kaplan <kaplan@debian.org> wrote:
> I'm not an ARM porter, and I don't find any info about this patch other
> than:
>>
>> Add 044-strtod_arm_fix.patch to fix the FPU confusion FTBFS on arm
>
>
> The patch is from 2005, so that's probably early builds with ARMEL.
>
> Does the patch make sense to you in any way? If not we'll drop it...
>

I think the patch does make sense, but only for doing floating point
arithmetic in PHP on very old hardware.
I am not sure if there are too many people that will benefit from this :-)

Regards,
Ard.