Re: Bug#251048: apache-common: listconffiles doesn't cope well with extra whitespace
tags 251048 pending
stop
Hi Colm,
thanks for the patch. It applies fine now.
Fabio
On Wed, 26 May 2004, Fabio Massimo Di Nitto wrote:
>
> Hi,
>
> On Wed, 26 May 2004, Colm Buckley wrote:
>
> > On 26 May 2004, at 18:23, Fabio Massimo Di Nitto wrote:
> >
> > > Can you kindly include the error you get and add comments to what you
> > > changed and why? I am not a perl expert and i am kinda unhappy to apply
> > > patches without someone reviewing them twice.
> >
> > Sure. The error is something like:
> >
> > "Can't read: /etc/apache/ foo.conf"
> >
> > Where httpd.conf contains a line like "Include<tab><tab><tab>foo.conf"
> > - ie: the tabs are being included in the filename.
> >
> > My patch changes the parsing of httpd.conf to account for additional
> > whitespace between the "Include" and "ServerRoot" directives and the
> > actual files and directories they correspond to. I seek two types of
> > line:
> >
> > <optional whitespace>Include<whitespace>"path"
> > <optional whitespace>Include<whitespace>path
> >
> > ie : paths with leading whitespace must be surrounded by " characters -
> > this matches Apache's parsing of the same files.
> >
> > The actual changes to the Perl are trivial - basically just changing
> > the regular expressions which match the ServerRoot and Include lines.
> >
>
> Thanks but the patch doesn't apply.
>
> patching file listconffiles
> Hunk #1 FAILED at 85.
> 1 out of 1 hunk FAILED -- saving rejects to file listconffiles.rej
>
> Fabio
>
> --
> <user> fajita: step one
> <fajita> Whatever the problem, step one is always to look in the error log.
> <user> fajita: step two
> <fajita> When in danger or in doubt, step two is to scream and shout.
>
>
>
--
<user> fajita: step one
<fajita> Whatever the problem, step one is always to look in the error log.
<user> fajita: step two
<fajita> When in danger or in doubt, step two is to scream and shout.
Reply to: