Bug#236882: apache-perl: New patch from mod_perl maintainer
Package: apache-perl
Version: 1.3.29.0.2-1
Severity: normal
Followup-For: Bug #236882
I brought this up on the mod_perl list and it turns out the upstream
patch was indeed a mistake.
Here's the message from Geoffrey Young, one of the MP dev folks:
Geoffrey Young wrote:
>>>>- if (!SvTRUE(RETVAL)) {
>>>>+ if (!SvOK(RETVAL)) {
ok, the attached patch fixes the problem. it turns out that XS as simple as
this
RETVAL = Nullsv;
if (!SvOK(RETVAL)) {
XSRETURN_UNDEF;
}
dumps core all on its own (without mod_perl's help :)
will be fixed in the next release (whenever that is)
--Geoff
Index: src/modules/perl/Apache.xs
===================================================================
RCS file: /home/cvs/modperl/src/modules/perl/Apache.xs,v
retrieving revision 1.130
diff -u -r1.130 Apache.xs
--- src/modules/perl/Apache.xs 1 Dec 2003 17:30:19 -0000 1.130
+++ src/modules/perl/Apache.xs 9 Mar 2004 18:41:50 -0000
@@ -2084,7 +2084,7 @@
&perl_module);
TABLE_GET_SET(c->vars, FALSE);
}
- if (!SvOK(RETVAL)) {
+ if (!(RETVAL && SvOK(RETVAL))) {
s = r && r->server ? r->server : perl_get_startup_server();
if (s && s->module_config) {
SvREFCNT_dec(RETVAL); /* in case above did newSV(0) */
-- System Information:
Debian Release: testing/unstable
APT prefers unstable
APT policy: (500, 'unstable')
Architecture: i386 (i686)
Kernel: Linux 2.4.24
Locale: LANG=C, LC_CTYPE=C
Versions of packages apache-perl depends on:
hi apache-common 1.3.29.0.2-2 Support files for all Apache webse
ii debconf 1.4.14 Debian configuration management sy
ii dpkg 1.10.19 Package maintenance system for Deb
hi libapache-mod-perl 1.29.0.2-2 Integration of perl with the Apach
ii libc6 2.3.2.ds1-11 GNU C Library: Shared libraries an
ii libdb4.2 4.2.52-12 Berkeley v4.2 Database Libraries [
ii libexpat1 1.95.6-8 XML parsing C library - runtime li
ii libmagic1 4.07-2 File type determination library us
ii libpam0g 0.76-15 Pluggable Authentication Modules l
ii libperl5.8 5.8.3-2 Shared Perl library.
ii mime-support 3.26-1 MIME files 'mime.types' & 'mailcap
-- debconf information:
apache-perl/old-pidfile-set:
* apache-perl/server-port: 80
* apache-perl/init: true
* apache-perl/enable-suexec: false
* apache-perl/document-root: "/var/www"
* apache-perl/upgrade-from-apache-conflict:
* apache-perl/server-name: localhost
* apache-perl/server-admin: autarch@houseabsolute.urth.org
Reply to: