[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1140316: binaryen: Please disable nodejs build dependency on unsupported architectures



Source: binary
Version: 120-4
Severity: important
Tags: patch
X-Debbugs-Cc: debian-alpha@lists.debian.org, debian-hppa@lists.debian.org, debian-68k@lists.debian.org, debian-powerpc@lists.debian.org, debian-superh@lists.debian.org, debian-sparc@lists.debian.org
User: debian-alpha@lists.debian.org
Usertags: alpha
User: debian-hppa@lists.debian.org
Usertags: hppa
User: debian-68k@lists.debian.org
Usertags: m68k
User: debian-powerpc@lists.debian.org
Usertags: powerpc ppc64
User: debian-superh@lists.debian.org
Usertags: sh4
User: debian-sparc@lists.debian.org
Usertags: sparc64

Hi,

binaryen currently has nodejs as a build dependency when tests are enabled.

Since nodejs is just available on a limited set of architectures, it would
be great if nodejs could be disabled for the architectures which don't
support it.

These would be:

- alpha
- hppa
- m68k
- powerpc
- ppc64
- sh4
- sparc64

Could you therefore change the debian/control and debian/rules as follows?

diff -Nru binaryen.old/binaryen-120/debian/control binaryen/binaryen-120/debian/control
--- binaryen.old/binaryen-120/debian/control    2025-02-13 12:59:01.000000000 +0100
+++ binaryen/binaryen-120/debian/control        2026-06-18 09:52:29.187327988 +0200
@@ -9,7 +9,7 @@
  python3,
  libgtest-dev,
  help2man,
- nodejs <!nocheck>,
+ nodejs [!alpha !hppa !m68k !powerpc !ppc64 !sh4 !sparc64] <!nocheck>,
 Standards-Version: 4.6.2
 Homepage: https://github.com/WebAssembly/binaryen
 Vcs-Git: https://salsa.debian.org/debian/binaryen.git
diff -Nru binaryen.old/binaryen-120/debian/rules binaryen/binaryen-120/debian/rules
--- binaryen.old/binaryen-120/debian/rules      2025-03-26 15:18:29.000000000 +0100
+++ binaryen/binaryen-120/debian/rules  2026-06-18 09:51:10.318131696 +0200
@@ -6,7 +6,7 @@
 
 buildDir = obj-${DEB_HOST_MULTIARCH}
 
-skip_tests_on_archs = s390x hppa powerpc ppc64 sparc64
+skip_tests_on_archs = s390x alpha hppa m68k powerpc ppc64 sh4 sparc64
 
 export DEB_BUILD_MAINT_OPTIONS = hardening=+all
 

Thanks,
Adrian

--
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer
`. `'   Physicist
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913
diff -Nru binaryen.old/binaryen-120/debian/control binaryen/binaryen-120/debian/control
--- binaryen.old/binaryen-120/debian/control	2025-02-13 12:59:01.000000000 +0100
+++ binaryen/binaryen-120/debian/control	2026-06-18 09:52:29.187327988 +0200
@@ -9,7 +9,7 @@
  python3,
  libgtest-dev,
  help2man,
- nodejs <!nocheck>,
+ nodejs [!alpha !hppa !m68k !powerpc !ppc64 !sh4 !sparc64] <!nocheck>,
 Standards-Version: 4.6.2
 Homepage: https://github.com/WebAssembly/binaryen
 Vcs-Git: https://salsa.debian.org/debian/binaryen.git
diff -Nru binaryen.old/binaryen-120/debian/rules binaryen/binaryen-120/debian/rules
--- binaryen.old/binaryen-120/debian/rules	2025-03-26 15:18:29.000000000 +0100
+++ binaryen/binaryen-120/debian/rules	2026-06-18 09:51:10.318131696 +0200
@@ -6,7 +6,7 @@
 
 buildDir = obj-${DEB_HOST_MULTIARCH}
 
-skip_tests_on_archs = s390x hppa powerpc ppc64 sparc64
+skip_tests_on_archs = s390x alpha hppa m68k powerpc ppc64 sh4 sparc64
 
 export DEB_BUILD_MAINT_OPTIONS = hardening=+all
 

Reply to: