[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: ci.rocm: invalid device function



Hi Christian,

Christian Kastner, on 2025-07-24:
> On 2025-07-24 09:29, Samuel Thibault wrote:
>> Christian Kastner, earlier:
>>> PS: If you are using rocm-target-arch in a package build, please also
>>> use the --for-build option, which will pick the arch list for the
>>> distribution in d/changelog. experimental currently has more arches
>>> then unstable.
>> 
>> I was surprised by the option name. It resonates with build/host/target
>> triples, but apparently it has nothing to do with that? I'd advise
>> renaming it to avoid confusion.
> 
> "build" unfortunately resonates with a lot of things. In this context,
> it refers to a package build, like dpkg-buildpackage would do.
[…]
> Thoughts, all?

If the word "build" is the problem, then how about unconfusing
with "--for-pkg-build"?  Or remove the "build" word entirely
with "--for-compilation"?  I guess the latter may make less
sense since dpkg-buildpackage builds packages without
necessarily always involving compiled language compilation
steps.

Naming things is hard, in hope this helps,
-- 
  .''`.  Étienne Mollier <emollier@debian.org>
 : :' :  pgp: 8f91 b227 c7d6 f2b1 948c  8236 793c f67e 8f0d 11da
 `. `'   sent from my alarm clock
   `-

Attachment: signature.asc
Description: PGP signature


Reply to: