[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1108246: marked as done (python3-rocm-docs: Hard-fails without internet access)

Your message dated Thu, 26 Jun 2025 06:04:23 +0000
with message-id <E1uUfih-000VcV-4L@fasolo.debian.org>
and subject line Bug#1108246: fixed in rocm-docs-core 1.20.0-1
has caused the Debian Bug report #1108246,
regarding python3-rocm-docs: Hard-fails without internet access
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1108246: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1108246
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: python3-rocm-docs
Version: 1.17.1-9
Severity: important
Tags: patch

Dear maintainer,

python3-rocm-docs generally assumes internet access, and hard-fails in
two cases, of which one can be worked around by setting the envvar
ROCM_DOCS_REMOTE_DETAILS.j

I have attached a proposed workaround for the other, by introducing an
envvar for this as well, ROCM_DOCS_SKIP_UPDATE_THEME_CONFIGS.

They way I see it, the skipped part is trivial. It just modifies the
theme based on whether this is a release, a candidate, latest, etc.

I tested this patch with rocrand 6.4 documentation build, and all looked
fine.

Best,
Christian
From: Christian Kastner <ckk@debian.org>
Date: Tue, 24 Jun 2025 07:17:28 +0200
Subject: Add option to skip theme update

It's possible for the host to not have internet access, so
_update_theme_configs either needs a way to exit early, or it needs to
handle the failed request.

This implements the former in a user-configurable way.
---
 src/rocm_docs/projects.py | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/rocm_docs/projects.py b/src/rocm_docs/projects.py
index 7aff032..9a0a261 100644
--- a/src/rocm_docs/projects.py
+++ b/src/rocm_docs/projects.py
@@ -342,6 +342,10 @@ def _update_theme_configs(
     app: Sphinx, current_project: _Project | None, current_branch: str
 ) -> None:
     """Update configurations for use in theme.py"""
+    # In case of no internet access
+    if "ROCM_DOCS_SKIP_UPDATE_THEME_CONFIGS" in os.environ:
+        return
+
     if latest_version := os.getenv('latest_version') is None:
        latest_version = requests.get(
         "https://raw.githubusercontent.com/ROCm/rocm-docs-core/data/latest_version.txt";

--- End Message ---
--- Begin Message --- 
Source: rocm-docs-core
Source-Version: 1.20.0-1
Done: Christian Bayle <bayle@debian.org>

We believe that the bug you reported is fixed in the latest version of
rocm-docs-core, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1108246@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Christian Bayle <bayle@debian.org> (supplier of updated rocm-docs-core package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Tue, 24 Jun 2025 16:24:32 +0200
Source: rocm-docs-core
Architecture: source
Version: 1.20.0-1
Distribution: unstable
Urgency: medium
Maintainer: Debian ROCm Team <debian-ai@lists.debian.org>
Changed-By: Christian Bayle <bayle@debian.org>
Closes: 1108246
Changes:
 rocm-docs-core (1.20.0-1) unstable; urgency=medium
 .
   * Add option-to-skip-theme-update (Closes: #1108246)
   * Set branch=latest to enable version display
   * Source only upload
Checksums-Sha1:
 ad59138b5710feaada929c2e96ce6a9eefdd15ee 2554 rocm-docs-core_1.20.0-1.dsc
 9235fc12ba2e4f7a32ff3bcc8a12156c6b009078 13592 rocm-docs-core_1.20.0-1.debian.tar.xz
 c8116504a414aa3db53a3c140c6ed35c56e24f20 15638 rocm-docs-core_1.20.0-1_amd64.buildinfo
Checksums-Sha256:
 74c3ef2180f45d7250a7c209e6bb853d908db92863f039ceda239ff2d678b511 2554 rocm-docs-core_1.20.0-1.dsc
 09b2c43cc0bdb412ca68596d0bdf1ac6c6b1a23c70da8df8cc8c8818aed3512e 13592 rocm-docs-core_1.20.0-1.debian.tar.xz
 f5e56e99604489d8c952e9a249cbe3bf8292bee0e30db46b2ae6ff84d39638f0 15638 rocm-docs-core_1.20.0-1_amd64.buildinfo
Files:
 0f4198fa411e8f1cdf6e0fcecedd66bb 2554 python optional rocm-docs-core_1.20.0-1.dsc
 3dc8d79445644683c87f0244eae24ceb 13592 python optional rocm-docs-core_1.20.0-1.debian.tar.xz
 42b13d8af34aa281358b81c8fdf22415 15638 python optional rocm-docs-core_1.20.0-1_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEl9DisSUYWvfJX+x3a5gt67/pHCkFAmhc34EACgkQa5gt67/p
HCnsGg/+JU5c2cC9FPVMZl0jmgs59czQ2lgn86P49wq4LX4cLz4TW/wFm4+s1UEp
ONKgfazfp5GcwHuOsWJjWA7Pl+kQf7pLEKL8KlXYGIv3FQWJcKBsJl/z39Bjqe17
pf/esK+77+N9Dr1Ft0Dv74L+QKv82mkPj1B8rKtYAtbKq/vYDtq5f8GP1ENFtueQ
5asS2Xd6Y7JCagxtJYqolCgIb8SFzHvdn2rz9e+RH4tRJDcwPON9/xEVzIs5nKph
Viwe/2p7uhV7GFP/JMHsGbTxsGjpGUlaTEdZxP0sWW7PtkDlyzbaGHUMjfpVag+i
+DqnhTo4Hx19ByNPa/ehI8xUepx8e+PJ+qTIjdNx+tdZbQBgttVAijsMRM0rwkid
dv80EUM8weLtKVBsWvnlk0G+CT1QFfnGsikEFtT4thbZmCpiMloEGvZc05Pr2SFC
iCXIukkeJMFVdEvWpk7kqAhzUrWQcjt5LybhGL6+XEdGO0p6a4qoNrX4h3wRbYef
WPwYXzj6kHN33RKUT6dgVLRIdQ/lvtQauQU0O3aLryunja55QYmVn+jOWY0zmkok
H5DgEi2+XyVnvvjWCwP7jNSnxyEuT+vs6rz3g2aAvFTKvF1uBHMvQ80QhiSQyQVa
+DZDc+9bQPvykOzIdUxVlKGEIuPC5ufSumCalaC/lwquTrF7KwM=
=ktlj
-----END PGP SIGNATURE-----

Attachment: pgpA4JcX1znrl.pgp
Description: PGP signature


--- End Message ---
Reply to: