[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Quick test on real hardware requested to test qemu



On 9/22/20 3:24 PM, John Paul Adrian Glaubitz wrote:
> On 9/22/20 3:22 PM, Andreas Schwab wrote:
>> On Sep 22 2020, John Paul Adrian Glaubitz wrote:
>>
>>> root@pacman:~# debfoster
>>> debfoster: /usr/include/atomic_ops/sysdeps/loadstore/atomic_load.h:31: AO_load: Assertion `((size_t)addr & (sizeof(*addr) - 1)) == 0' failed.
>>
>> That a typical bad alignment check.  It should use __alignof__, not
>> sizeof.
> 
> Aha, I was assuming something like that already but I wasn't sure since libatomic-ops wasn't
> updated for a while in Debian [1].

What would be the correct check then in [1]?

Adrian

> [1] https://github.com/ivmai/libatomic_ops/blob/master/src/atomic_ops/sysdeps/loadstore/atomic_load.h#L31

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaubitz@debian.org
`. `'   Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913


Reply to: