[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [PATCH 2/2] input: atakbd.c - fix Atari CapsLock behaviour



Thanks Dmitry!

I had asked Andreas' signoff for his keymap fixes only - the rewrite of the Atari keyboard driver to the current input framework (and hence the CapsLock toggle bug) was entirely mine, no blame attaches to Andreas there.

Cheers,

    Michael



On 18/09/18 10:36, Dmitry Torokhov wrote:
On Mon, Sep 17, 2018 at 10:29:08PM +0200, Andreas Schwab wrote:
On Sep 17 2018, Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:

On Fri, Sep 07, 2018 at 11:40:43AM +1200, Michael Schmitz wrote:
The CapsLock key on Atari keyboards is not a toggle, it does send the
normal make and break scancodes.

Drop the CapsLock toggle handling code, which did cause the CapsLock
key to merely act as a Shift key.

Tested-by: Michael Schmitz <schmitzmic@gmail.com>
Signed-off-by: Michael Schmitz <schmitzmic@gmail.com>
Andreas, I have no idea how Atari keyboards work, can you add your
signed-off-by (or NAK) to this one as well please?
The old atakbd driver never had that special handling.

Signed-off-by: Andreas Schwab <schwab@linux-m68k.org>
Applied, thank you.



Reply to: