[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#780430: qtwebkit-opensource-src: port to m68k



Hi Adrian!

On Mon, Oct 17, 2016 at 04:02:50PM +0200, John Paul Adrian Glaubitz wrote:
> On 10/17/2016 04:00 PM, Lisandro Damián Nicanor Pérez Meyer wrote:
> > Correction: no, I can't forward it to *my* upstream: QtWebkit is not developed 
> > anymore.
> >
> > It needs to be accepted by WebKit developers. I don't have the time for this, 
> > so please feel free to do it.
>
> Ah, interesting. I wasn't aware that these particular changes are part of
> WebKit and not the derived Qt version of it.
>
> If Andreas agrees, I'm happy to forward his patch. I bet the people at
> Apple would be surprised to see someone adds support for m68k :). They
> used that architecture for a long time, after all.

I am currently working on updating QtWebKit package to the new codebase [1],
based on upstream WebKit 212 (initial version is available in experimental).

Patch in this bug no longer applies to the new version. Patch from webkit2gtk
package [2] applies with a slight change, but I still do not like the special
casing of struct sizes. Why are the sizes different on m68k? Maybe adding some
padding like in Thorsten’s original patch (in this bug) would help here?

In any case, please do forward the patch upstream as you promised. Please see
[3] for some instructions. Having m68k support upstream will help both us and
the GTK+ port.

[1]: https://github.com/annulen/webkit/
[2]: http://sources.debian.net/src/webkit2gtk/2.17.5-1/debian/patches/fix-ftbfs-m68k.patch/
[3]: https://webkit.org/contributing-code/

--
Dmitry Shachnev

Attachment: signature.asc
Description: PGP signature


Reply to: