Bug#752833: Bug#749452: RFS: gnustep-gui/0.24.0-1

[Yavor Doganov <yavor@gnu.org>]

Paul Gevers wrote:
> On 04-07-14 22:31, Yavor Doganov wrote:
> > (#752833), it is pointless to upload without a fixed -make.

gnustep-make was uploaded, but nevertheless thanks very much for the
review.

> While looking at gnustep-make, I noticed the following:
> gnustep-make: Possible OpenPGP signature found at:

> Could you please do that?

I didn't do it because the public key was not available on the
keyservers.  However, later on I figured out that it's in the keyring
at Savannah, so I'll do it in the next upload.

> I get quite a lot of lintian messages (end of the attached build log).
> Can you please have a look? Also lintian warns me for: gnustep-make:
> package-contains-empty-directory usr/lib/GNUstep/* It seems installation
> of files is not going well.

These are expected; the package creates an empty directory layout.
The broken symlinks to config.{sub,guess} is a lintian false positive;
they are not actually broken.
I have submitted a patch upstream for the spelling errors.

> I don't like commit b5d1db. What happens when the package is NMU'ed?

I think it'll be OK:

$ dpkg --compare-versions 2.6.6-2.1 lt 2.6.6-2.1.1~ || echo no
$ dpkg --compare-versions 2.6.6-2+nmu1 lt 2.6.6-2+nmu1.1~ || echo no

> Minor things on the use of the git repository: I recommend tagging a
> Debian release only at the moment of or after upload.

Of course.  I tagged it a few hours ago, only after I saw it was
uploaded in the archive.

> Furthermore, to avoid confusion it is not uncommon to have the
> release marked as UNRELEASED until the final upload.

Sure, but since I uploaded it to mentors.d.n, supposedly to be
uploaded directly by a DD to the official archive, it ought to have a
valid distribution field.

Thanks.