[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#654154: Please enabled hardened build flags



Source: libxfont
Severity: important
Tags: patch

Please enabled hardened build flags through dpkg-buildflags.

Patch attached. (dpkg-buildflags abides "noopt" from DEB_BUILD_OPTIONS)

Cheers,
        Moritz
diff -aur libxfont-1.4.4.orig/debian/rules libxfont-1.4.4/debian/rules
--- libxfont-1.4.4.orig/debian/rules	2012-01-02 03:58:33.000000000 +0100
+++ libxfont-1.4.4/debian/rules	2012-01-02 03:59:11.000000000 +0100
@@ -11,12 +11,11 @@
 
 include debian/xsfbs/xsfbs.mk
 
-CFLAGS = -Wall -g
-ifneq (,$(filter noopt,$(DEB_BUILD_OPTIONS)))
-	CFLAGS += -O0
-else
-	CFLAGS += -O2
-endif
+CFLAGS = `dpkg-buildflags --get CFLAGS`
+CFLAGS += -Wall
+LDFLAGS = `dpkg-buildflags --get LDFLAGS`
+CPPFLAGS = `dpkg-buildflags --get CPPFLAGS`
+
 ifneq (,$(filter parallel=%,$(DEB_BUILD_OPTIONS)))
 	NUMJOBS = $(patsubst parallel=%,%,$(filter parallel=%,$(DEB_BUILD_OPTIONS)))
 	MAKEFLAGS += -j$(NUMJOBS)
@@ -48,7 +47,7 @@
 	             --infodir=\$${prefix}/share/info $(confflags) \
 	             --with-bzip2 \
 	             --with-xmlto --without-fop \
-	             CFLAGS="$(CFLAGS)" LDFLAGS=""
+	             CFLAGS="$(CFLAGS)" CPPFLAGS="$(CPPFLAGS)" LDFLAGS="$(LDFLAGS)"
 
 build-udeb/config.status: configure
 	mkdir -p build-udeb
@@ -57,7 +56,7 @@
 	             --infodir=\$${prefix}/share/info $(confflags) \
 	             --without-bzip2 \
 	             --without-xmlto --without-fop \
-	             CFLAGS="$(CFLAGS)" LDFLAGS=""
+	             CFLAGS="$(CFLAGS)" CPPFLAGS="$(CPPFLAGS)" LDFLAGS="$(LDFLAGS)"
 
 build: build-stamp
 build-stamp: build/config.status build-udeb/config.status
Nur in libxfont-1.4.4/debian: rules~.

Reply to: