[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#338245: framebuffer driver does not set display width properly if used without Shadow



Am Donnerstag, 10. November 2005 10:03 schrieb Michel Dänzer:
> I'm not sure what you mean here, but it's certainly true that the fbdev
> driver has grown a lot of warts over the years. Are you volunteering for
> a rewrite? :)

Not now, maybe later when I have time to dig a bit more into it. It would not 
help when someone like me just adds other problems.

> Anyway, my question about why you duplicate the code from FBDevPreInit()
> instead of moving it stands.

I am sorry that I did not read your question properly last time. I am not sure 
if this code is necessary for some special case in FBDevPreInit. At least it 
does not do any harm there, so I left it. But you are right, maybe it is not 
needed there, and then it should be removed. Also to get a bit more towards 
clear code ;-) But this needs to be investigated before. I will do that when 
I have time again.

> Not sure how the rest of the XSF would like this to be handled, but you
> could e.g. tag them as upstream.

I will first wait for some other comments on that.

Peter Teichmann



Reply to: