--- Begin Message ---
- To: submit@bugs.debian.org
- Subject: www.debian.org: not robust to CRLF (dos end of lines): items missing from indexes/get_recent_list
- From: Simon Paillard <spaillard@debian.org>
- Date: Sun, 5 Sep 2010 23:56:36 +0200
- Message-id: <20100905215636.GB5104@dedibox.ebzao.info>
Package: www.debian.org
Severity: important
Hi,
As experienced since today with the announcement of Lenny 5.0.6, dos
(CRLF) end of lines doesn't match some regex.
As a consequence, the announce did not appear in any News listing
(either homepage or /News/ /News/2010), while a french translation
without CRLF of the same file does appear.
Affected file :
english/template/debian/recent_list.wml
Maybe other regex in the website are affected as well.
Other way could be a pre-commit hook that forbids or issues a warning
on CRLF.
--
Simon Paillard
--- End Message ---
--- Begin Message ---
- To: Simon Paillard <spaillard@debian.org>, 595698-done@bugs.debian.org
- Subject: Re: Bug#595698: www.debian.org: not robust to CRLF (dos end of lines): items missing from indexes/get_recent_list
- From: David Prévot <david@tilapin.org>
- Date: Wed, 27 Apr 2011 23:44:59 -0400
- Message-id: <4DB8E2BB.8090606@tilapin.org>
- In-reply-to: <20110426182845.GP532__33993.2346171283$1303842809$gmane$org@glenfiddich.ikibiki.org>
- References: <20100905215636.GB5104@dedibox.ebzao.info> <4D56E988.2050503@altern.org> <[🔎] 4DB46051.1070808@tilapin.org> <20110426182845.GP532__33993.2346171283$1303842809$gmane$org@glenfiddich.ikibiki.org>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Le 26/04/2011 14:28, Simon Paillard a écrit :
> On Sun, Apr 24, 2011 at 01:39:29PM -0400, David Prévot wrote:
>> Le 12/02/2011 16:11, David Prévot a écrit :
>>> tags 595698 patch
>>
>> Simon, anyone, any comment on the patch?
>> http://bugs.debian.org/cgi-bin/bugreport.cgi?msg=10;filename=relax_eol_for_define-tag.patch;att=1;bug=595698
>>
>> If noone objects, I'll commit it in a few days (and yes, I use it
>> locally for more than two month, it solves the issue spotted earlier,
>> and I do wonder why I didn't commit it earlier ;-).
>
> Perfect, I guess you grepped for '$/' ?
'>$/' actually, so there might still exist other corner cases. Since
there are already many CRFL files that don't break anything (and I fixed
some faulty headers while taking care of the breadcrumbs: the build
could now fails if a file is broken on that regard, which may actually
be a good point, better anyway than the silent error that triggered this
BR).
Regards
David
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
iQIcBAEBCAAGBQJNuOK5AAoJELgqIXr9/gnyx0AP/1MoW+7x11ojXbhqmMJs5knG
5USHnErtLMTwkGI36+Oc2rJVP2soWzarkVZYYu430Uu2fBwl4yM5AxXflfir5qok
OXuu+Oef8baF0TA/KpruMC5XEeTbFkD1STw7H/f1vuu5xOTB2KEtA7RUqLoi0m7K
O4yo28ZJt9WuAqIZsVP+3x5eK4AmzjCAFQzDc9ahc2ysPxICLixKvpVe+jiPtReT
3oskIVJ5uBvty/HjVfxXBYynS7KSzUDJqG5jNjXjr+XSziy3eSsYhEwpOAYxYErY
C/+ZCFHe+Z4CofTeSh/CX2Wo34VGr2/ka0SZqkqO0xywZQ1i28iA+BC7ynUmfWU5
xD4rwD6VIsZiRhS7BpJ10JM6MpueiScXyNcFrTbX1sN8ckCB83ZGF2l3x45cqCw8
MrJWz72DY8Cym8Ssv7w9WplqcWRzbV619xa/sbmYQ6XKKeIP08BQYJcBAnbS80nq
c/f+ORSDn7E7xpvnv10EjqLT+7JVFkMSl0EQsjCXRbSRAlDAl3vY3MVnhfpnYE9b
+xCgx1yyrv0Gbdw9ljxvm7ceWTpz87+A7DWXThWrNmIqLADhW/CJMj77FQz7wHjN
U753H+WLuckqFpYk6PS3vWho/42fpVSxoiDy7UIXCR6LXsnyQCYakxKazIAxvFAO
KRgK9qnu8qyvzm/0md6u
=LW/z
-----END PGP SIGNATURE-----
--- End Message ---