Bug#613293: RFS: svgsalamander (updated, take 3)
-----BEGIN PGP SIGNED MESSAGE-----
On 2011-03-27 14:24, Nicolas Dandrimont wrote:
> I have contacted upstream with my questions about svgsalamander. He
> answered quickly but I took some time to get back to work.
That happens :) Personally I am still waiting for 25 hour days! >.>
> My latest work is available in pkg-java's git repo :
> I updated the package for latest upstream (svn rev. 0095). Upstream
> doesn't intend to do and keep track of a formal release, so I'm keeping
> the debian version simple (well, modulo the 00, but anyways...).
I am thinking that 0~svn95 might still be a better version; you never
know what the future brings. Maybe upstream start making formal
releases if/as more people get involved in it.
Obviously we could still handle that with an epoch, so using 95 (or
0095) as a version would not be the end of the world for us.
> I removed use of the embedded batik code copy as upstream intends it for
> compatibility with Java5 and older. It is still in the source so the
> copyright info is still there.
If you are "repacking" the source package anyway (which you did for the
PDF), please remove this copy as well. Since we have lost the "pristine
tar" (or rather, there never was a tarball to begin with?) we might as
well reduce the risks of compiling/using the embedded code copy (not to
mention reduce the size of the tarball).
> I think svgsalamander should be quite ready for upload now.
> Latest source is available from mentors.d.n at
> - URL: http://mentors.debian.net/debian/pool/main/s/svgsalamander
> - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free
> - dget http://mentors.debian.net/debian/pool/main/s/svgsalamander/svgsalamander_0095-1.dsc
> Thanks in advance,
> Nicolas Dandrimont
I also noted a minor thing like "cd $dir && dostuff && cd $(CURDIR)".
The last cd $(CURDIR) is not necessary (every line is executed in a
separate shell). This is a feature of "make".
The dh --with maven_repo_helper can be written as "maven-repo-helper".
Personally I find the dashed version nicer to read (but this is a
"pedantic" personal preference).
Unfortunately I did not have a lot of time to look at it this time
(either?), so no build testing or anything done today.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
-----END PGP SIGNATURE-----