RE: Patch to add resolution information to iscan
Thank you for your interest in using our products and services.
> -----Original Message-----
> From: Ross Boylan [mailto:RossBoylan@stanfordalumni.org]
> Sent: Sunday, July 27, 2003 10:47 AM
> To: PIPS News Release; email@example.com; Ross Boylan
> Subject: Re: Patch to add resolution information to iscan
On Sunday, July 27, Ross Boylan wrote:
> [OK, this time with the patch!]
> On Sat, Jul 26, 2003 at 03:42:59PM -0700, Ross Boylan wrote:
> > I have attached a patch so that iscan, scanning software for Epson
> > scanners from Epson Kowa, will record the scanning resolution when
> > saving .png files. Without this, some programs (e.g., hylafax) have
> > to assume a resolution, and can be terribly wrong. (I was inspired to
> > do this because only the lower left corner of my 400 dpi scans was
> > going out, since they were assumed to be postscript standard 72dpi).
Sounds like this may be a useful addition to "Image Scan! for Linux".
> > I'm not sure if all versions of libpng support pHYS; if not, it
> > might
> > be good to protect the code with some appropriate ifdef's. I had
> > libpng10-dev (aka libpng2) as my development library when I compiled
> > with gcc 3.3.
For those of you who haven't been following Ross' postings, he's doing all his building on a Debian system. The corresponding package name for Red Hat 9 is libpng10-devel although you're probably better of sticking with libpng-devel. On Debian stay with libpng-dev. # The PNG libraries have been going through a bit of version changes.
> > Despite the name, I have used and applied the patch to iscan 1.5.2,
> > gcc 3.2 version. I originally developed it against 1.5.1.
> > I (c) in my name and release it under GNU Public License v2 or
> > later;
> > I believe this is the same license as the software it is patching,
> > which is available at
> > http://www.epkowa.co.jp/english/linux_e/lsd_e.html.
Although probably with the best intentions, releasing your patch under the GPL makes it unusable for us. The reason for this is that the iscan program links with a proprietary library. All source code for the iscan program carries a special exception that explicitly permits this kind of linking. Without this exception, the GPL does not permit us to link with that library. The exception reads:
As a special exception, EPSON KOWA Corporation gives permission
to link the code of this program with the esmod library and
distribute linked combinations including the two. You must obey
the GNU General Public License in all respects for all of the
code used other then esmod.
If you would reconsider the licensing of your patch, we can probably use it as is.
Then some nit-picking about the copyrighting :-)
It would get very cumbersome to maintain the source code if we have to keep track of the copyright owners for all patches, especially for the kind of minor patches that add/change relatively little in the sources (like your patch does). # If you were to add new files, then there is probably no problem if # you want to claim copyright on those files.
Would it be okay with you if we acknowledge your contribution in an AUTHORS file and keep the copyright of the files you modified as is? # This AUTHORS file is currently missing, but can easily be added.
> > P.S. There are some other changes I'd like to make, like having
> > iscan
> > remember whether you selected png or pnm, and having it remember what
> > directory you are in. I think that requires learning about gtk
> > preferences, though.
These also sound like useful little additions, so are you going to hit the books? :-)
EPSON KOWA Corporation