[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#625792: marked as done ([britney2] Needs to be cleverer at deciding which packages to check for installability)

Your message dated Thu, 02 Jun 2011 23:26:22 +0100
with message-id <eb7df030cfb85820fa007741744ca9d9@localhost>
and subject line Re: Bug#625792: [britney2] Needs to be cleverer at deciding which packages to check for installability
has caused the Debian Bug report #625792,
regarding [britney2] Needs to be cleverer at deciding which packages to check for installability
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
625792: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=625792
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
User: release.debian.org@packages.debian.org
Usertags: britney

Hi,

With the fix for #624716 applied, b2 no longer crashes attempting to
migrate xfce and friends (via "hint exo").  It does fail the hint,
however, whereas b1 successfully migrated the package set based on the
same input.

Having spent a little while trying things, so I don't forget any of it,
and in case anyone else spots a clean and obvious solution, my thoughts
and analysis on that are below...

The process of deciding which packages need checking for installability
is roughly (see doop_source()):

if source in testing
  for each binary still built from this source in testing
    mark all reverse dependencies as affected [A]
add new source to testing
for each binary built from the new source
  mark the binary as affected [B]
  if the binary exists in testing
    mark all reverse dependencies as affected [C]
    mark all reverse conflicts as affected [D]
  add / update the binary
  mark the new reverse dependencies as affected [E]

Hinting exo initially results in cairo-dock-plugins, cairo-dock (via
c-d-p) and ristretto being flagged as newly uninstallable.  The first
two are easily fixable by applying the patch from #614249 to steps C and
E; step D uses get_full_tree() which is considerably slower but the
number of reverse conflicts is generally small enough that it doesn't
matter.  Resolving ristretto turns out to be more complicated,
unfortunately.

The exo hint involves a number of source packages which provide
ristretto's reverse dependencies.  In the order in which they're
considered:

exo
- mark ristretto as affected (step A)
- ristretto becomes uninstallable

libxfcegui4
- mark ristretto as affected (step A)
- ristretto is still uninstallable

thunar
- mark ristretto as affected (step A)
- ristretto is still uninstallable

thunar-vfs
- the source isn't in testing; so steps A, C and D are skipped
- unstable's ristretto doesn't depend on libthunar-vfs-1-2, so the
package isn't marked for checking again

The net effect is that ristretto is left (incorrectly) marked as
uninstallable and the hint fails.  This is a little bit of a corner case
(due to unstable's ristretto having dropped the dependency) but should
still be fixed.

Regards,

Adam

--- End Message ---
--- Begin Message --- 
On Mon, 30 May 2011 20:15:16 +0100, Adam D. Barratt wrote:
So, the solution to this turned out to be reasonably simple, although it 
took me a while to see that.  iter_packages() has a list of undo
dictionaries for the entire exo hint, which includes the fact that the 
previous version of libthunar-vfs-1-2 had ristretto as a
reverse-dependency; the fix is to make doop_source() aware of that undo 
information.

Patch attached.  I'll probably push it in a day or so unless anyone
yells or points out issues with it.
I did that earlier today, and it's survived a live run without exploding or producing a diff; closing. 

Regards,

Adam

--- End Message ---
Reply to: