[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [RFR] templates://kde4libs/{kdelibs5.templates}



On Saturday 17 October 2009 06:54:35 Christian Perrier wrote:
> Please find, for review, the debconf templates and packages descriptions
>  for the kde4libs source package.
>
> This review will last from Saturday, October 17, 2009 to Tuesday, October
>  27, 2009.

Full NACK.  You are changing the message. We are not moving from .kde to 
.kde4.

/Sune
 
> Please send reviews as unified diffs (diff -u) against the original
> files. Comments about your proposed changes will be appreciated.
> 
> Your review should be sent as an answer to this mail.
> 
> When appropriate, I will send intermediate requests for review, with
> "[RFRn]" (n>=2) as a subject tag.
> 
> When we will reach a consensus, I send a "Last Chance For
> Comments" mail with "[LCFC]" as a subject tag.
> 
> Finally, the reviewed templates will be sent to the package maintainer
> as a bug report, and a mail will be sent to this list with "[BTS]" as
> a subject tag.
> 
> Rationale:
> --- kde4libs.old/debian/kdelibs5.templates	2009-10-08 14:48:45.688656288
>  +0200 +++ kde4libs/debian/kdelibs5.templates	2009-10-12 22:25:35.766828119
>  +0200 @@ -7,26 +7,17 @@
>  Default: true
>  _Description: Stop possible unsafe upgrade of KDE4 with running sessions?
>   You are about to upgrade to the new version of the kdelibs5 package which
> - introduces a major configuration change. Newly started KDE 4 applications
> - will use ~/.kde directory to store user settings and data (also known as
> - KDEHOME) by default while currently running KDE 4 applications use
>  ~/.kde4. - KDE 3 applications have always used (and will continue to use)
>  ~/.kde. It - seems that there are a few KDE 4 applications running on your
>  system at the - moment. To avoid potential setting/data loss, you should:
> + introduces a major configuration change. Details are given in
> + /usr/share/doc/kdelibs5/README.Debian: in short, user settings are moved
> + from ~/.kde to ~/.kde4.
>   .
> - 1) Answer "Yes", terminate all KDE applications and KDE sessions and try
> + Some KDE 4 applications are currently running (${apps}). It is
>  recommended + to abort the upgrade of kdelibs5, terminate all KDE
>  applications and KDE sessions and try upgrading again.
>   .
> - or 2) Answer "No" to continue upgrading. You should make sure that no new
> - KDE 4 applications are started before you migrate your KDE 4 settings and
> - data.  Beware, that clean termination of the old KDE 4 session might not
>  be - safe..
> - .
> - Once upgrade is complete, login to KDE as usual or you may use Kaboom
>  wizard - (package name: kaboom) to migrate your user settings and data
>  before starting - any KDE 4 application.
> - .
> - Currently running KDE 4 applications: ${apps}
> + If you choose to coontinue the upgrade, you should make sure that no new
> + KDE 4 applications are started before KDE 4 settings and data are
>  migrated. + A clean termination of the old KDE 4 session might not be
>  safe.
> 
> The original template was way too long and was trying to say too many
> things. It generally triggers more problems than it solves.
> 
> Also, the original template was making references to specific aspects
> of the interface ('Yes' and 'No' answers) that may vary depending on
> the debconf interface and locale settings.
> 
> So, I rewrote the template entirely, trying to say the same important
> information in a shorter way.
> 
> I indeed propose moving the gory details about ~/.kde and ~/.kde4 in a
> README.Debian file.
> 
>  Template: kdelibs5/upgrade_kdehome_info_title
>  Type: title
> @@ -40,7 +31,7 @@
>   KDE 4 applications use ~/.kde4. KDE 3 applications has always used (and
>  will continue to use) ~/.kde.
>   .
> - When upgrade is complete, it is safe to login to KDE as usual or, if you
>  are + When the upgrade is complete, it is safe to login to KDE as usual
>  or, if you are only using individual KDE 4 applications, you may use
>  Kaboom (available in the - package of the same name) wizard to migrate
>  your user data before starting a + package of the same name) wizard to
>  migrate user data before starting a KDE 4 application.
> 
> Add missing article.
> 
> Drop "your": the user doing the upgrade is not necessarily owning the
> data.
> 
> PS: I did not review packages descriptions in debian/control.
> 

-- 
Do you know how to overclock a device from the control tools inside Photoshop?

You never have to cancel the editor and then from the folder menu within Excel 
you should install the RW gadget to uninstall on a level-6 LCD prompt on a 
virus over the attachment on a tool.


Reply to: