Bug#253901: marked as done (Wish: Bitrate info in tabs/columns)
Your message dated Fri, 10 Sep 2004 17:29:22 +0200
with message-id <200409101729.23080.suy@badopi.org>
and subject line Closing properly
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 11 Jun 2004 19:26:51 +0000
>From james@westcoastbmx.com Fri Jun 11 12:26:51 2004
Return-path: <james@westcoastbmx.com>
Received: from relay1.hrnoc.net [216.120.226.254]
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1BYrfv-0005DA-00; Fri, 11 Jun 2004 12:26:51 -0700
Received: from smtp-1.hrnoc.net ([216.120.225.37])
by relay1.hrnoc.net with esmtp (Exim 4.32; FreeBSD)
id 1BYrfz-000KJs-Ry
for submit@bugs.debian.org; Fri, 11 Jun 2004 15:26:55 -0400
Received: (qmail 1724 invoked by uid 509); 11 Jun 2004 19:26:48 -0000
Received: from james@westcoastbmx.com by smtp-1.hrnoc.net by uid 89 with qmail-scanner-1.20st
(clamuko: 0.70. spamassassin: 2.63. Clear:RC:0(66.234.217.95):SA:0(0.0/6.0):.
Processed in 0.323942 secs); 11 Jun 2004 19:26:48 -0000
X-Qmail-Scanner-Mail-From: james@westcoastbmx.com via smtp-1.hrnoc.net
X-Qmail-Scanner: 1.20st (Clear:RC:0(66.234.217.95):SA:0(0.0/6.0):. Processed in 0.323942 secs)
Received: from astound-66-234-217-95.ca.astound.net (HELO ?192.168.1.101?) (james@westcoastbmx.com@66.234.217.95)
by smtp-1.hrnoc.net with SMTP; 11 Jun 2004 19:26:47 -0000
From: james mcguire <james@westcoastbmx.com>
To: submit@bugs.debian.org
Subject: Wish: Bitrate info in tabs/columns
Date: Fri, 11 Jun 2004 12:26:48 -0700
User-Agent: KMail/1.6.2
MIME-Version: 1.0
Content-Disposition: inline
Content-Type: text/plain;
charset="us-ascii"
Content-Transfer-Encoding: 7bit
Message-Id: <200406111226.48118.james@westcoastbmx.com>
X-HR-Scan-Signature: cbd01ea9dc6be7e8a4f9aa1a80eb91c7
X-HR-SA-Score: ()
X-HR-Status: HR_AVScanned-(james@westcoastbmx.com/216.120.225.37)
Delivered-To: submit@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_25
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-7.0 required=4.0 tests=BAYES_01,HAS_PACKAGE
autolearn=no version=2.60-bugs.debian.org_2004_03_25
X-Spam-Level:
Package: juk
Version: 4:3.2.2-1
Severity: wishlist
*** Please type your report below this line ***
I would like to be able to view the quality/bitrate of my files in a
column(tab) in juk (just like artist, album, etc.). This wish was already
requested on KDE.org, and they already have the wish completed (bug report
page is here: http://bugs.kde.org/show_bug.cgi?id=78882).
Thanks!
Here is the patch:
CVS commit by wheeler:
Add a bitrate column (hidden by default).
CCMAIL:78665-done@bugs.kde.org
M +2 -0 playlist.cpp 1.182
M +17 -5 playlistitem.cpp 1.83
M +3 -2 playlistitem.h 1.54
--- kdemultimedia/juk/playlist.cpp #1.181:1.182
@@ -170,4 +170,5 @@ Playlist::SharedSettings::SharedSettings
for(int i = 0; i <= PlaylistItem::lastColumn(); i++) {
switch(i) {
+ case PlaylistItem::BitrateColumn:
case PlaylistItem::CommentColumn:
case PlaylistItem::FileNameColumn:
@@ -868,4 +869,5 @@ void Playlist::polish()
addColumn(i18n("Year"));
addColumn(i18n("Length"));
+ addColumn(i18n("Bitrate"));
addColumn(i18n("Comment"));
addColumn(i18n("File Name"));
--- kdemultimedia/juk/playlistitem.cpp #1.82:1.83
@@ -78,4 +78,6 @@ QString PlaylistItem::text(int column) c
case LengthColumn:
return d->fileHandle.tag()->lengthString();
+ case BitrateColumn:
+ return QString::number(d->fileHandle.tag()->bitrate());
case CommentColumn:
return d->fileHandle.tag()->comment();
@@ -260,5 +262,6 @@ int PlaylistItem::compare(const Playlist
}
- if(column == TrackNumberColumn + offset) {
+ switch(column - offset) {
+ case TrackNumberColumn:
if(firstItem->d->fileHandle.tag()->track() >
secondItem->d->fileHandle.tag()->track())
return 1;
@@ -267,6 +270,6 @@ int PlaylistItem::compare(const Playlist
else
return 0;
- }
- else if(column == LengthColumn + offset) {
+ break;
+ case LengthColumn:
if(firstItem->d->fileHandle.tag()->seconds() >
secondItem->d->fileHandle.tag()->seconds())
return 1;
@@ -275,8 +278,17 @@ int PlaylistItem::compare(const Playlist
else
return 0;
- }
+ break;
+ case BitrateColumn:
+ if(firstItem->d->fileHandle.tag()->bitrate() >
secondItem->d->fileHandle.tag()->bitrate())
+ return 1;
+ else if(firstItem->d->fileHandle.tag()->bitrate() <
secondItem->d->fileHandle.tag()->bitrate())
+ return -1;
else
+ return 0;
+ break;
+ default:
return strcoll(firstItem->d->local8Bit[column - offset],
secondItem->d->local8Bit[column - offset]);
+ }
}
--- kdemultimedia/juk/playlistitem.h #1.53:1.54
@@ -58,6 +58,7 @@ public:
YearColumn = 5,
LengthColumn = 6,
- CommentColumn = 7,
- FileNameColumn = 8 };
+ BitrateColumn = 7,
+ CommentColumn = 8,
+ FileNameColumn = 9 };
static int lastColumn() { return FileNameColumn; }
-- System Information:
Debian Release: testing/unstable
APT prefers unstable
APT policy: (500, 'unstable')
Architecture: i386 (i686)
Kernel: Linux 2.4.26extra2
Locale: LANG=C, LC_CTYPE=C
Versions of packages juk depends on:
ii kdelibs4 4:3.2.3-1 KDE core libraries
ii libart-2.0-2 2.3.16-5 Library of functions for
2D graphi
ii libarts1 1.2.3-1 aRts Sound system
ii libasound2 1.0.5-1 Advanced Linux Sound Arc
hitecture
---------------------------------------
Received: (at 253901-done) by bugs.debian.org; 10 Sep 2004 15:30:25 +0000
>From suy@badopi.org Fri Sep 10 08:30:25 2004
Return-path: <suy@badopi.org>
Received: from 34.red-80-32-129.pooles.rima-tde.net (stewie) [80.32.129.34]
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1C5nM1-0004ca-00; Fri, 10 Sep 2004 08:30:25 -0700
Received: by stewie (Postfix, from userid 1000)
id 9B0F87B5AB; Fri, 10 Sep 2004 17:29:23 +0200 (CEST)
From: Alejandro Exojo <suy@badopi.org>
Organization: http://www.badopi.org/
To: 253901-done@bugs.debian.org
Subject: Closing properly
Date: Fri, 10 Sep 2004 17:29:22 +0200
User-Agent: KMail/1.7
MIME-Version: 1.0
Content-Type: text/plain;
charset="us-ascii"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200409101729.23080.suy@badopi.org>
Delivered-To: 253901-done@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_25
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-3.0 required=4.0 tests=BAYES_00 autolearn=no
version=2.60-bugs.debian.org_2004_03_25
X-Spam-Level:
Martijn Pieters tried to close the bug, but forgot to CC control@b.d.o.
Since this is fixed in 3.3, I'm closing.
Reply to: