[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Help with konq-speaker crash



Ben Burton writes:

>> I've debugged this ...

> Ah, thanks.  I had misunderstood the behaviour of
> KProcess::DontCare.

np.

>> To be honest, konq-speaker source is pretty bad, if it doesn't even
>> factor out common code in both plugins.

> FWIW, I can understand the author not wanting to split out a shared
> library for what is about 12 lines of common code in two very small
> plugins.

Okay, I didn't realise there was so little common code.  But still,
it's likely to get expanded ( software always is ;) ), and even if not
putting it into a shared lib, a separate noinst_LTLIBRARY would still
be a very good idea imho.

> Anyway, thanks heaps for sorting that out.  Now to make the patches
> and upload. :)

Have fun :)

cheers
domi



Reply to: