Re: request NMU for Stephen Stafford's apt-spy package
On Wed, Jul 27, 2005 at 04:37:47PM +0100, Stephen Stafford wrote:
> Quoting Justin Pryzby <email@example.com>:
> > Hi,
> > Could someone consider NMUing apt-spy with at least that patch?
> Sorry I've not had time to deal with this properly. I had hoped to
> have some time last week, but it didn't happen :(
> Please NMU if you wish. The quick glance I gave to the all of the
> patches from Justin look good. An NMU to sid with all the patches
> would be fine.
Could you comment on the intent of the code which pertains to #317585:
"apt-spy: build_country_file() initializes country_code as a function
of its own strlen()"?
I think that
country_code = malloc(strlen(country_code));
is meant to be
country_code = malloc(strlen(country_list));
but, see also my comment about making country_code a small, statically
allocated array (of 4 characters or so). By static, I mean: "char
country_code;", unless its used outside of that function and its
callees, in which case it really does needs to be "static char
country_code;" (or allocated at a higher level).