Re: Bug#365471: libpdf-report-perl: addImgScaled() method disregards the scaling parameter does a simple addImg()
Niko Tyni dijo [Sun, Apr 30, 2006 at 10:29:36PM +0300]:
> I suppose you didn't notice that libpdf-report-perl is currently using
> dpatch for managing the patches.
> While I'm aware that there are different opinions on whether dpatch
> (and other such patch systems) are a good idea, I suppose everybody can
> agree that mixing dpatch and 'straightforward' .diff.gz patching gives
> the worst of the both worlds.
> Please consider making this patch into a dpatch as well or removing
> the dpatch framework. I introduced it in 1.30-4 because I thought the
> .diff.gz was getting confusing with four independent patches.
> I wonder if we (as in pkg-perl-maintainers) should have a policy about
> patch systems? If people think that the SVN history keeps patches
> separate enough, that's of course fine by me. The only situation where
> that doesn't apply is when the patches are older than the first import
> to our SVN repository.
I completely agree - I for one favor dpatch on everything, as it
improves clarity given we are a largish team... I just have not
converted anything to dpatch, and was waiting for Debconf to be over
so I have some time to learn it (I expect it to be stupidly easy :) )
and convert some of my and our packages.
Gunnar Wolf - email@example.com - (+52-55)5623-0154 / 1451-2244
PGP key 1024D/8BB527AF 2001-10-23
Fingerprint: 0C79 D2D1 2C4E 9CE4 5973 F800 D80E F35A 8BB5 27AF