Van: Bart Martens [mailto:firstname.lastname@example.org] Namens Bart Martens
Verzonden: dinsdag 5 juni 2012 7:20
Aan: Bas van den Dikkenberg; email@example.com
Onderwerp: RFS: ptop/3.6.2-7
I suggest to do the following changes:
- Remove machine/m_gnu.c from debian/patches/ptop_hurd,
- Add "cp -f machine/m_linux.c machine/m_gnu.c" to debian/rules,
Not done, i adjusted the configure file to use m_linux.c so no copy is needed
- Add debian/clean containing "machine/m_gnu.c",
Not done, i adjusted the configure file to use m_linux.c so no cleaning is needed
- Add similar changes for the other arch(s) with the same problem,
- Rename debian/patches/ptop_hurd to debian/patches/archs,
- Update "Architecture:" in debian/control.
I'm not sure about removing hppa and powerpcspe from ptop's archs list because I don't know the issue with debhelper on these archs. Is it really a permanent problem ? Maybe ptop can have "Architecture: any".
states "No entry in hppa database, check Packages-arch-specific" but this page https://buildd.debian-ports.org/quinn-diff/sid/Packages-arch-specific
seems to fail at this time.
I looked this up:
"must be accompanied by a verbatim copy of its copyright information"
"should name the original authors"
Added to copyright
I see in the file LICENSE that William LeFebvre is copyright holder but that is not yet mentioned in debian/copyright. That's a "must" for debian-policy.
I see that there are quite some authors. Mentioning them in debian/copyright is a "should" for debian-policy. To help you with listing them, I found these authors so far:
Andrew S. Townley
Except Mark Wong i added them as coauthors,
Do I need to add there email address also ?
If not oke please email, if uploaded a new version to mentors
I think that the list is pretty complete, but it's possible that I've missed a few. I have left out the e-mail addresses to prevent complaints about spam. I suggest to add this list to debian/copyright. It's a "should" for debian-policy.