Le vendredi, 14 octobre 2011 11.31:25, Marco Balmer a écrit : > Dear mentors, > > I am looking for a sponsor for a my new debian package: > > * Package name : aspsms-t Hi Marco, and thanks for this new package, indeed probably useful (too) to have in Debian ! So here's my review: * debian/copyright: same remark as jabber-querybot's: you probably want to use "GPL-2+", otherwise OKay. * Again (and sorry, eh…), I don't find the descriptions of tremendous quality: e.g. the first paragraph of the long description is not even a sentence; the rest is more descriptive of technical internals than "tool caracteristics". As machine administrator, when reading the description, I want to know what this package does as a whole; details of transaction numbers for delivery notifications are probably more suitable in documentation than in description. * Library splitting: Not knowing much of perl (you should maybe contact [pkg- perl] to get better opinions), I wonder if the bunch of files under /usr/share/perl5/ASPSMS/ would not be best suited in a separate libaspsms-perl package, don't know. Cheers, OdyX [pkg-perl] http://pkg-perl.alioth.debian.org/
Description: This is a digitally signed message part.