Re: RFS: leechcraft (closes ITP bug, new attempt)

[Boris Pek <Tehnick-8@yandex.ru>]

Hi,

>>  Direct link:
>>    http://mentors.debian.net/debian/pool/main/l/leechcraft/leechcraft_0.4.90-1.dsc
>
> A couple of notes and random nitpickings:
>
> * The package description of leechcraft-incubator suggests it is a meta
>   package, yet, it only depends on ${misc:Depends}, and has no .install
>   file, either.

I deleted those unstable plugins but forgot to delete this meta-package. Now fixed. Thanks.

> * In debian/rules, instead of figuring out the upstream version from the
>   changelog yourself, you could include /usr/share/dpkg/pkg-info.mk, and
>   use DEB_VERSION_UPSTREAM (though, that introduces a build-dependency
>   on a recent dpkg)

I am pleased with the current implementation.

> Other than this, the package looks fine at a first glance.

Sounds promising.

Updated package is at the same location:
  http://mentors.debian.net/debian/pool/main/l/leechcraft/leechcraft_0.4.90-1.dsc

Best regards,
Boris