Re: RFS: pygame

[Vincent Cheng <vincentc1208@gmail.com>]

On Thu, Oct 6, 2011 at 1:58 AM, Ansgar Burchardt <ansgar@debian.org> wrote:
> Vincent Cheng <vincentc1208@gmail.com> writes:
>
>> On Fri, Sep 30, 2011 at 11:59 AM, Ansgar Burchardt <ansgar@debian.org> wrote:
>>> Vincent Cheng <vincentc1208@gmail.com> writes:
>>>> All right, repacked and re-uploaded to mentors.d.n:
>>>>
>>>> $ dget -x http://mentors.debian.net/debian/pool/main/p/pygame/pygame_1.9.1release+dfsg-2.dsc
>>>
>>> I am not an expert on python packages, but it looks okay to me with one
>>> exception: debian/rules hardcodes python versions (2.6 and 2.7).  This
>>> should ideally not be done and I can see two ways to avoid this: either
>>> create the symlink before running setup.py so that it will be installed
>>> the normal way (remember to remove it later), or use shell globbing to
>>> match $(CURDIR)/debian/python-pygame/usr/lib/python* instead of giving
>>> explicit versions.
>>
>> Fixed.
>
> Sorry, I did not test this myself before sending my earlier mail, but
> the build process copied the font file referenced by the symlink
> (instead of copying only the symlink itself).
>
> Could you try the other alternative then?
>

Done.

As always, I've uploaded my revised packaging to mentors.d.n:

$ dget http://mentors.debian.net/debian/pool/main/p/pygame/pygame_1.9.1release+dfsg-2.dsc

Thanks!

Vincent