Am Samstag, den 30.10.2010, 18:31 +0200 schrieb Gabriele Giacone: > > Anyway, renamed. > > > > http://mentors.debian.net/debian/pool/main/u/ubiquity-mozilla/ubiquity-mozilla_0.6-1.dsc I did a quick review: 1) Please rename the source package to ubiquity-extension (or xul-ext-ubiquity). We don't want to have mozilla in the name any more (all extension of our team [1] have no mozilla in it) and all extensions that have a conflicting source name uses -extension as prefix: * imap-acl-extension * notify-extension * sage-extension 2) You use features of mozilla-devscripts 0.22 [2]. Please adjust the Build-Depends. 3) "${xpi:Recommends} (>= 3.6)" doesn't work, because multiple items could be generated. If you want versioned Recommends, mozilla-devscripts needs to be adjusted. 4) Don't rely on the installation destination of install-xpi (run by dh_auto_install). It may change in the future. Run "install-xpi -i /usr/share/xul-ext/$(NAME) [...]" instead of dh_auto_install. 5) You may be interested in xpi-repack to get rid of the get-orig-source rule (more details in the man page). [1] http://qa.debian.org/developer.php?login=pkg-mozext-maintainers@lists.alioth.debian.org [2] http://wiki.debian.org/mozilla-devscripts -- Benjamin Drung Ubuntu Developer (www.ubuntu.com) | Debian Maintainer (www.debian.org)
Attachment:
signature.asc
Description: This is a digitally signed message part