* Michael Fladischer <firstname.lastname@example.org>, 2010-03-29, 10:19:
Issues with upstream code: - According to upstream README, "the implementation is taken and adopted from [a snippet] by Taavi Taijala"; this is apparently in contrast with the only copyright statement (in setup.py): "Copyright (c) 2009 Shrubbery Software". Could you please clarify this with upstream? - According to docstrings "the pickling protocol is specified explicitly (by default 2)", which is not true (unless I'm blind).I've uploaded a new version of the package with fixed pickling protocol version handling and clarified copyright statements. All my patches were included in upstream. http://mentors.debian.net/debian/pool/main/d/django-picklefield/django-picklefield_0.1.3-1.dsc
I can't see how the copyright issue was resolved. We have Copyright (c) 2009-2010 Gintautas Miliauskas in setup.py, and Copyright (c) 2009, Shrubbery Software Copyright (c) 2009, Taavi Taijala Copyright (c) 2007, Oliver Beattie in debian/copyright...There are some stale files in debian/ that should be removed from the source package:
debian/python-picklefield.* debian/python-module-stampdir debian/stamp-patchedTests should not be run if nocheck build option is enabled (see Debian Policy 4.9.1 and bug #568897).
It would be nice if tests were run with all versions of Python your package supports. `pyversions -r` can give you such a list.
You could try to generate upstream changelog from the README file. -- Jakub Wilk
Description: Digital signature