Re: RFS: ttf-isabella (updated package)
Here is a review:
Please remove the defoma stuff and clean up the resulting obsolete
conffiles. Please note that the x-ttcidfont-conf instructions in
README.Debian will then be incorrect and should be removed. You can
find examples of how to do this in the pkg-fonts team SVN repository.
We're trying to remove defoma for squeeze:
debian/bug/presubj (and README.Debian) doesn't need to mention
libfreetype6/libxft2/fontconfig since debian/bug/script already takes
care of that. debian/bug/script should probably handle changes in the
ABI number in the libfreetype or libxft package names. README.Debian
probably doesn't need to duplicate debian/bug/presubj.
README.Debian doesn't need to contain authorship or copyright info,
that is in debian/copyright.
README.Debian doesn't need to contain the upstream homepage, that
should be in the Homepage field in debian/control.
You might want to get the Description in debian/control reviewed:
Are you Edgar Antonio Palma de la Cruz or Tony Palma? It is very
confusing that you use both names with one email address.
As per above, x-ttcidfont-conf will go away with defoma, so please
drop that from recommends. Fonts can be used without fontconfig
installed, so please either drop the fontconfig recommends or maybe
downgrade it to suggests. Anything that uses fontconfig to find fonts
will depend on it anyway, so I would suggest just removing it.
Please add a debian/watch file, see uscan(1) for more details. There
is a new upstream version available (1.2), a watch file would have
helped you detect this before asking for a sponsor. Also, upstream
links to Isabella-1.2-src.tar.gz but it is not available, please ask
them to fix that.
In debian/copyright there is no information about the
copyright/license for everything in debian/*
The upstream readme says the font is GPL but the COPYING.LIB and .sfd
contains the LGPL. Please ask upstream to fix README.txt.
The fontconfig section in debian/postinst should no longer be needed,
IIRC fontconfig has triggers for generating its cache now.
I'd suggest using the new debhelper 7 dh stuff, see the slides and
video from DebConf9 for more info:
An example is here:
dh7 dh_bugfiles should take care of the bug script/presubj. I think
the only thing you'll need to override will be dh_auto_build and
I: ttf-isabella source: debian-watch-file-is-missing
P: ttf-isabella: no-upstream-changelog
P: ttf-isabella: no-homepage-field
P: ttf-isabella: maintainer-script-without-set-e postinst
You might want to consider joining the pkg-fonts team.
The fontlint tool gives some warnings, please test the latest upstream
with fontlint and inform upstream of any issues:
Warning: Mac string is a subset of the Windows string in the 'name' table
for the Sample Text string in the English (US) language.
The glyph named mu is mapped to U+00B5.
But its name indicates it should be mapped to U+03BC.
The glyph named dotlessj is mapped to U+F6BE.
But its name indicates it should be mapped to U+0237.
A point in Iogonek is outside the font bounding box data.
A point in Scommaaccent is outside the font bounding box data.
A point in uni021A is outside the font bounding box data.
A point in uni1EC2 is outside the font bounding box data.
Validation Isabella ...Failed
Self Intersecting Glyph
Missing Points at Extrema
Bad Glyph Name
Bad 'CFF ' table
In future you can also see these on the pkg-fonts review pages. Right
now the index is being updated, so the page for Isabella.ttf may not
be available. The pkg-fonts team would welcome any help to improve the
Upstream might also want to look at the pkg-fonts template for open
fonts and adopt some of the conventions, please point them at it: