[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: ziproxy (updated package)



On Sat, Dec 12, 2009 at 11:28:19AM -0500, Marcos Talau wrote:
> Dear mentors,
> 
> I am looking for a sponsor for the new version 2.7.2-1
> of my package "ziproxy".
> 
> It builds these binary packages:
> ziproxy    - compressing HTTP proxy server
> 
> The package appears to be lintian clean.
> 
> The upload would fix these bugs: 521051 (Grave), 543471, 543494
> 
> The package can be found on mentors.debian.net:
> - URL: http://mentors.debian.net/debian/pool/main/z/ziproxy
> - Source repository: deb-src http://mentors.debian.net/debian unstable main
>   contrib non-free
> - dget http://mentors.debian.net/debian/pool/main/z/ziproxy/ziproxy_2.7.2-1.dsc
> 
> I would be glad if someone uploaded this package for me.
> 
> Kind regards,
> Talau

Hi!

/--- debian/rules
| build: patch build-stamp
\---

	For me that looks like you can't depend on patch having finished
when build-stamp runs. So theoretically on a parallel build the whole
build target could have ben run before your sources are patched. I
doubt you want that. That's the only blocker I have found so far for
this package.

	Minor point, you have $(TMP_DIR) = $(CURDIR)/debian/ziproxy but in
install you use

/---
| $(MAKE) DESTDIR=$(CURDIR)/debian/ziproxy install
\---

	If you decide to switch to the new 3.0 source format you can use
the bzip2 tarball from upstream unmodified (and get some extra
benefits like automagic quilt handling) -- just a random thought
wouldn't prevent me from sponsoring.

	Commenting the quilt patches (as suggested by lintian!) would be
really nice, I found myself trying to figure out what some patch was
supposed to do way too often. (The other Info level stuff might be
interesting for you was well).

Regards

	Christoph

-- 
/"\  ASCII Ribbon : GPG-Key ID: 0xD49AE731
\ /    Campaign   : CaCert Assurer
 X   against HTML : Debian Maintainer
/ \   in eMails   : http://www.debian.org/

http://www.christoph-egger.org/

Attachment: signature.asc
Description: Digital signature


Reply to: