Re: RFS: nd (updated package)
On Wed, Nov 25, 2009 at 07:02:09PM +0100, Mats Erik Andersson wrote:
> Dear mentors,
>
> I am looking for a sponsor for the new version 0.8.2-3
> of my package "nd".
Great! Comments below.
Since your NMU did not get uploaded to Debian, you should be okay to
combine the two debian/changelog entries.
It looks to me like your debian/rules could be reduced almost as far
as /usr/share/doc/debhelper/examples/rules.tiny, but adding a --with
quilt option to dh. I haven't tested this, but it would make it
easier to understand (for me). If you do this, you need Build-Depends
as described at:
http://pkg-perl.alioth.debian.org/debhelper.html#dh___with_quilt
Is debian/nd.dirs really meant to contain /usr/bin?
debian/nd.docs is superfluous - debian/copyright doesn't need to be in
there, and the two README files and the empty NEWS file are pretty
useless.
You should add http://gohome.org/nd/ as a Homepage field in
debian/control.
I'll give it another review if you fix these. :) I think I just need
to check the copyright matches the source.
--
Tim Retout <tim@retout.co.uk>
Reply to: