Re: RFS: arc-colors
Hi Andrew, Benjamin,
On Fri, 1 May 2009 10:56:29 -0400 Andrew wrote:
> > BTW, I wonder whether gnome-colors isn't too generic for a package [that
> > is not officially from GNOME].
> >
>
> We debated what to use as the package names and in the end decided on
> staying close to the upstream name for the meta-package while using
> the *-icon-theme naming convention on the individual theme binaries.
> We felt that it would be confusing to use something different from
> upstream for the package pulling in all five themes. GNOME-Colors is
> very well known. 161,654 downloads through the GNOME-Look to date. As
> to it not being officially from GNOME, there seem to be many packages
> in the archive that are named gnome-foo without being officially from
> GNOME.
No real problem with this, just wondered a bit :)
Now listen what I have found in the three packages:
First of all: they build fine in a clean cowbuilder and in an unclean
sid environment, are lintian clean and seem to work fine (I'm not using
GNOME, so I wasn't able to test the metacity theme, only the Xfwm one).
Second: you use cdbs, which is mainly a blackbox for me. Nothing
against you using it, just don't expect answers on questions about it :)
Now come my remarks.
Package versions/links:
gnome-colors 3.1-1 and not 3.0.5-1
shiki-colors 3.8-1 and not 3.5-1
You usually want to post a follow-up to your initial RFS, so potential
sponsors notice the change.
*/debian/control:
+ Vcs-Bzr should be Vcs-Browser? Vcs-Bzr should be a URL one can
checked out directly.
+ Some Descriptions start with an "a" -- that shouldn't be there.
*/debian/copyright:
+ You write "Copyright: (C) ...", that's AFAIK legally wrong, you
either have to write "Copyright" or ©
+ You don't provide a revision of the Wiki page you're refering to,
and as a wiki might change, I'd add it like this:
http://wiki.debian.org/Proposals/CopyrightFormat?action=recall&rev=454
+ You co-maintain the packages, but only Andrew has copyright?
shiki-colors-3.8/debian/control:Package: shiki-colors-xfwm-theme
+ I'd add an "Xfce4" somewhere to the description (like Xfwm/Xfce4
theme based ...) as people tend to search for Xfce and not for Xfwm
(or at least I do ;))
+ Depends: xfwm4, but shiki-colors-metacity-theme does not depend on
metacity but gtk2-engines-clearlooks? I have no idea about
GNOME/Metacity, maybe you just need to explain this one to me :)
gnome-colors-3.1/debian/copyright:
+ You write Copyright (C) 2009, Victor C.<perfectska04@gmail.com>, but
AUTHORS says stuff is taken from Tango etc, this should be listed in
copyright too
+ This maybe apply to the other packages too, but they do not contain
an AUTHORS file
gnome-colors-3.1/Extras:
+ I wonder about the copyright/source of those?
That's all for now, maybe I find more, but I hope not :)
Regards
Evgeni
--
Bruce Schneier Fact Number 76:
Bruce Schneier PGP signs his grocery lists so that he can detect if
someone has tampered with his milk.
Reply to: