Re: RFS: salasaga (updated package)
* Iulian Udrea <email@example.com> [080919 17:03]:
> I am looking for a sponsor for the new version 0.8.0~alpha4-1
> of my package "salasaga".
Your build system will run autogen and configure multiple times.
Please make build depend on the appropiate patch-stamp file instead of
patch directly and do not make it phony (usual way it to make it a
build-stamp target, create build-stamp file at the end and make build
simply depend on build-stamp).
I've currently no sid system with enough build-depends available to
test, but your clean target really looks like not cleaning enough.
Please try to run dpkg-buildpackage -S after a dpkg-buildpackage and
look at the .diff.gz, I'd be suprised if there weren't a myriad of
additional files in there (at least I see nothing removing Makefile
or Makefile.in and stuff like that).
Your debian/copyright states it is LGPLv3 but does not point to the
copy of the license in /usr/share/common-licenses/LGPL-3.
You do not list the copyright holders of intl/ (17692 lines in .c files
is not little), ide/font_outline/ArevCopyright.txt lists a copyright
holder not found in there, and perhaps other files, too...
Also having the package under LGPL 3 and the debianisation under GPL 2
looks strange to problematic to me...
I've only looked at debian/rules and debian/copyright, other files might
have other problems...
Bernhard R. Link