Re: RFS: fslint (updated package)
Cameron Dale wrote:
> Hi Pádraig,
> I might be able to sponsor this, but I have some concerns below.
> On 5/20/08, Pádraig Brady <P@draigbrady.com> wrote:
>> Dear mentors,
>> I am looking for a sponsor for the new version 2.26-1
>> of my package "fslint".
>> It builds these binary packages:
>> fslint - A utility to fix problems with filesystems' data, like duplicate
>> The package appears to be lintian clean.
> Upgrade your lintian and fix these problems:
> N: Processing source package fslint (version 2.26-1) ...
> W: fslint source: out-of-date-standards-version 3.7.2 (current is 3.7.3)
> I: fslint: desktop-entry-contains-encoding-key
> /usr/share/applications/fslint.desktop:8 Encoding
> N: The Encoding key is now deprecated by the FreeDesktop standard and all
I can't change this without a patch to my release
Will fix in next release if that's OK.
> W: fslint: description-contains-homepage
> N: The extended description contains a "Homepage:" pseudo-header
> N: following the old Developer's Reference recommendation. As of 1.14.6,
> N: dpkg now supports Homepage: as a regular field in debian/control. This
> N: header should be moved from the extended description to the fields for
> N: the relevant source or binary packages.
> Some more comments:
> Unless you released 2.25-1 somewhere else, merge the unreleased 2.25-1
> and 2.26-1 changelog entries into one 2.26-1, otherwise the bugs
> probably won't get closed automatically.
Neil commented why this is not necessary
> The changelog entry for 2.22-2 disappeared, add it back in.
> Not required, but the use of the many install commands in the rules
> file should, in my opinion, be made more understandable by using
> debhelper's dh_install command and a separate fslint.install file.
> Also not required, but the use of perl to set the location of the
> installed files in the fslint-gui program should be replaced by a
> patch, using quilt (preferably) or dpatch, so that it is more clear
> exactly what is being changed from upstream.
I'll fix those up in fslint-2.28 (comming soon).