Re: RFS: lynis
IANADD so I cannot sponsor your upload. However I think my comments may
be useful for you. CC'ing my AM: Eventually he has additional comments
and/or is willing to sponsor your upload, when everything okay.
On Thu, Feb 14, 2008 at 01:22:42AM +0100, Francisco García wrote:
> - dget http://mentors.debian.net/debian/pool/main/l/lynis/lynis_1.0.8-1.dsc
I would suggest you to remove the changelog entry for 1.0.7-1, as
appearently 1.0.8-1 will be the first release in Debian. Some people argue
that there is no need to hide the development of a package from the target
audience of changelogs, but IMHO the first changelog entry contains
practical no information (its redundant, anyway) and is confusing (due to
- Misses a homepage header to indicate upstream url. See 
- Should include a license excerpt. If you have dh-make installed,
see /usr/share/debhelper/dh_make/licenses/gpl for an example.
- IMHO the "," between the copyright year and your name is not needed
- nitpick: Not so beauty are the useless empty spaces at and eof line:)
- What do you think about adding the machine-parseable fields to copyright?
Are you sure you need it? Seems to me like you won't need it, if you'd do
minor modifications to your debian/rules file
- Dou you really need the (useless) comments that are added by dh-make?
- configure-stamp target misses a touch configure-stamp
- same for build-stamp (simply uncomment your touch ;)
- install: Please remove the commented make install call if you don't need
- you could use the install -D parameter with your install calls and avoid
to create directories seperateley. However this only works for the install
calls where you only install single files.
- it would make sense to delete the useless empty lines (1 or two lines
between targets is fine, but it does not make much sense two have 5 or
more onfollowing empty lines)
- where is the point to call dh_makeshlibs - your package does not contain
shared libraries, does it?
- debian/lynis.manpages is useless as you only install one manpage. you can give
it as an argument to dh_installmanpages.
- debian/watch is missing but is highly recommended! This enables you to track
new upstream versions automatically via your qa page (and via mail
notification!). See 
- RFS: lynis
- From: Francisco García <email@example.com>