Re: RFS: statist - Small and fast terminal-based statistics program

[Mario Iseli <mario@marioiseli.com>]

On Mon, 2005-12-26 at 21:36 -0200, Jakson A. Aquino wrote:
> Hello!

Hi!

> This package was discussed here before, but I didn't find a sponsor yet.
> Below, some information about it:

I think this is a very interesting package, so i take me a little time
to review it. Poorwise i'm not a DD yet, so i can't help you with
sponsoring.

debian/changelog:
OK

debian/copyright:
- Architecture: any
+ Architecture: all

-Depends: ${shlibs:Depends}, ${misc:Depends}
+Depends: ${shlibs:Depends}
(You don't need the second variable, it isn't defined anywhere...)

  Homepage: http://wald.intevation.org/projects/statist/
This is a bit a problem, i'm also not sure because everybody makes it a
bit different, i thought it has to be like that (no warranty):
 Homepage:  <http://.....>

debian/copyright:
- It was downloaded from http://wald.intevation.org/projects/statist
+ It was downloaded from <http://wald.intevation.org/projects/statist>
(+/- can't be ommitted)

- Copyright Holder:  1997-1999 Dirk Melcher
-                    1998-2005 Bernhard Reiter <bernhard@intevation.de>
-                    2005 Jakson Aquino <jaksonaquino@yanoo.com.br>
+ Copyright Holders:	Dirk Melcher <where.is@the.email.org?>
			1998-2005 Bernhard Reiter <bernhard@intevation.de>
+			 2005 Jakson Aquino <jaksonaquino@yanoo.com.br>
(1. plural form; 2. i think the years can here be ommitted)

The License-part has no valid copyright! Should be something like that:
License:

Copyright (C) 1989-2005  Mario Iseli <admin@marioiseli.com>

This is free software......

debian/rules:
clean:
testdir and testroot not needed.
binary-arch:
dh_installchangelogs (should this not install YOUR debian/changelog?)
dh_installdocs (useless: you have to provide a debian/docs or remove
this)

The rest i think should work, i compile it now and test it a bit. :-)

Regards,
Mario