Re: your mail
Hi Yaroslav,
On 3 January 2012 02:16, Yaroslav Halchenko <debian@onerussian.com> wrote:
> * Author: Andrei Zavada <johnhommer@gmail.com>
> * Parts from PhysioToolKit (http://www.physionet.org/physiotools,
> * by George B. Moody (george@mit.edu))
After studying debian maintainer's guide, I changed it as follows:
---8<---
Format: http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/Upstream-Name:
AghermannUpstream-Contact: Andrei Zavada <johnhommer@gmail.com>Source:
http://johnhommer.com/academic/code/aghermann/source
Files: *Copyright: 2008-2012 Andrei Zavada <johnhommer@gmail.com>License: GPL-2+
Files: src/libexstrom/exstrom.hhCopyright: 2007 Exstrom Laboratories
LLC http://www.exstrom.comLicense: GPL-2+
Files: src/libsigfile/psd.hhCopyright: 1980-2010 George B. Moody
<george@mit.edu>License: LGPL-2
---8<---
The file includes the text of a short version of GPL-2 (even though
the guide says citing common licenses like this is not necessary). I
know including the full text will not hurt; but perhaps I should
either also include the text of LGPL-2, or exclude both? Is it ok to
exclude the text of both licenses altogether (as I provisorily did)?
>
> additionally IIRC according to DEP-5 shouldn't have double Copyright: fields
>
> Copyright: 2007 Exstrom Laboratories LLC
> 2010-2012 Andrei Zavada
>
> also add 'License: GPL-2+' prior that detached paragraph with the license (I
> know that here it would look like a duplicate but actually it just opens the
> paragraph and tells what it is about, so those references to GPL-2+ license now
> have the 'destination')
Fixed.
> also the last (most recent) changelog entry should close the ITP, so should be something like
>
> Initial Debian release (Closes: #650393) and distribution could be
> changed from UNRELEASED to unstable.
Now the topmost entry in debian changelog goes:
---8<---
aghermann (0.4.4-1) unstable; urgency=low
* Initial Debian release (Closes: #650393).
* Version bump.
---8<---
If the proposed changes are ok, I'll make them into a tarball and
upload in some 10h.
Cheers,
Andrei
Reply to: