Bug#655562: scripts/build/lb_binary_syslinux is not defensive enough against misconfiguration
tag 655562 pending
On 01/12/2012 12:10 PM, Martin Quinson wrote:
> - the configuration must be checked at the beginning of the process (to
> ensure that typo such as hhd instead of hdd are detected and reported
> in a timely manned)
yep, like i said on irc.
also, it should be a warning (with a sleep 5 or so only, not an exit 1,
remember the drop in of custom local formats), patches welcome.
> - the call to mkdir must be protected: mkdir without argument will
> always fail on the user, so you don't want to do that. I'm not sure
> whether the code should fail if puzzled or if the mkdir should simply
> be avoided, but I'm sure you'll know.
falling back to hdd seems to be the right thing to do here, done in git.
> Anyway, thanks for this very nice piece of software, and keep up the
> good work.
Address: Daniel Baumann, Donnerbuehlweg 3, CH-3012 Bern