[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [PATCH] do not eject USB flash drives



Ronny Standtke wrote:
> 1) unsafe $blah instead of ${blah}

this is not a syntax error, it's just bad style.

> 2) == instead of = (bashism)

this is not a syntax error, it's just a bashism.

> 3) a missing whitespace (which was my most frequent error when I started 
> writing shell scripts because I come from whitespace agnostic programming 
> languages)

that's the cornercase. ;)

> All in all it looks like the "-n" option is poorly documented and 
> implementation is incomplete. Am I wrong or is it time to write a bug report 
> to bug-bash@gnu.org?

looks like.

-- 
Address:        Daniel Baumann, Burgunderstrasse 3, CH-4562 Biberist
Email:          daniel.baumann@panthera-systems.net
Internet:       http://people.panthera-systems.net/~daniel-baumann/


Reply to: