Please find, for review, the debconf templates and packages descriptions for the nodm source package.
This review will last from Wednesday, April 08, 2009 to Saturday, April 18, 2009.
Please send reviews as unified diffs (diff -u) against the original
files. Comments about your proposed changes will be appreciated.
Your review should be sent as an answer to this mail.
When appropriate, I will send intermediate requests for review, with
"[RFRn]" (n>=2) as a subject tag.
When we will reach a consensus, I send a "Last Chance For
Comments" mail with "[LCFC]" as a subject tag.
Finally, the reviewed templates will be sent to the package maintainer
as a bug report, and a mail will be sent to this list with "[BTS]" as
a subject tag.
Rationale:
--- nodm.old/debian/nodm.templates 2009-03-30 08:43:14.772543104 +0200
+++ nodm/debian/nodm.templates 2009-04-04 08:17:17.775986571 +0200
@@ -2,23 +2,29 @@
Type: boolean
Default: false
_Description: Start nodm on boot?
- nodm starts an X session for a user without asking for authentication. While
- this is welcome for embedded or kiosks systems, it is a security problem in
- most other machines, so by default nodm is configured not to start.
+ Designed for embedded or kiosks systems, nodm starts an X session
+ for a user without asking for authentication. On regular
+ machines, this has security implications and is therefore disabled
+ by default.
.
- If you need autologin on this machine, enable nodm.
+ You should enable nodm only if you need autologin on this machine.
I revamped the first paragraph to avoid it beginning lowercase. Also,
I re-mixed the two sentences to make it more natural and immediately
say what nodm is about. In short, please read this as "I prefer my
version over yours"..:)
Revert the second sentence to avoid imperative form.
Template: nodm/user
Type: string
Default: root
_Description: User to start a session for:
- Name of the user that will automatically be logged into X by nodm.
+ Please enter the login name of the user that will automatically be logged into X by nodm.
Make sentences....
Template: nodm/x_options
Type: string
Default: vt7 -nolisten tcp
+#flag:translate!:3
_Description: Options for the X server:
- Options to pass to the X server when starting the session.
+ Please enter the options to pass to the X server when starting the session.
+ These options will be used in the NODM_X_OPTIONS variable in the command line used
+ by nodm to start the X session:
+ .
+ $NODM_XINIT $NODM_XSESSION -- $NODM_X_OPTIONS
I'm unsure about "Please enter the options". Sounds too French for
being good. Anyway, Justin will correct if needed..:-)
Anyway....I made this clearer by adding an extra sentence and use the
example you're using in another template.
Please note that the paragraph alon with variables is marked as non translatable.
Template: nodm/min_session_time
Type: string
@@ -31,18 +37,22 @@
Template: nodm/xinit
Type: string
Default: /usr/bin/xinit
+#flag:translate!:3
_Description: xinit program to use:
- You can change this to use a different xinit program.
+ Please choose the name of the "xinit" program to use with nodm. That
+ name will be stored in the NODM_XINIT variable in the command line used
+ by nodm to start the X session:
.
- nodm will start the X session with the command:
$NODM_XINIT $NODM_XSESSION -- $NODM_X_OPTIONS
Similar changes
Template: nodm/xsession
Type: string
Default: /etc/X11/Xsession
+#flag:translate!:3
_Description: X session to use:
- You can change this to use a different X session script.
+ Please choose the name of the X session script to use with nodm. That
+ name will be stored in the NODM_XSESSION variable in the command line used
+ by nodm to start the X session:
.
- nodm will start the X session with the command:
$NODM_XINIT $NODM_XSESSION -- $NODM_X_OPTIONS
Similar changes
--- nodm.old/debian/control 2009-03-30 08:43:14.841226598 +0200
+++ nodm/debian/control 2009-04-04 08:17:47.487986804 +0200
@@ -12,11 +12,11 @@
Architecture: any
Depends: xinit, x11-common, xterm | x-terminal-emulator, ${shlibs:Depends}, ${misc:Depends}
Conflicts: gdm, xdm, kdm, x-display-manager, zhone-session
-Description: Automatic Display Manager
+Description: automatic display manager
This packages prepares the system to automatically start an X session at
system boot. It is targeted for devices like smartphones, but can be used
a regular computer as well, if the security implications are acceptable.
.
- It should not be installed on a regular Debian system, as it would interfere
+ It should not be installed on a regular system, as it would interfere
with an installed display manager.
Uncapitalize the synopsis
Unbranding.
--
Template: nodm/enabled Type: boolean Default: false _Description: Start nodm on boot? Designed for embedded or kiosks systems, nodm starts an X session for a user without asking for authentication. On regular machines, this has security implications and is therefore disabled by default. . You should enable nodm only if you need autologin on this machine. Template: nodm/user Type: string Default: root _Description: User to start a session for: Please enter the login name of the user that will automatically be logged into X by nodm. Template: nodm/x_options Type: string Default: vt7 -nolisten tcp #flag:translate!:3 _Description: Options for the X server: Please enter the options to pass to the X server when starting the session. These options will be used in the NODM_X_OPTIONS variable in the command line used by nodm to start the X session: . $NODM_XINIT $NODM_XSESSION -- $NODM_X_OPTIONS Template: nodm/min_session_time Type: string Default: 60 _Description: Minimum time (in seconds) for a session to be considered ok: If an X session will run for less than this time in seconds, nodm will wait an amount of time before restarting the session. The waiting time will grow until a session lasts longer than this amount. Template: nodm/xinit Type: string Default: /usr/bin/xinit #flag:translate!:3 _Description: xinit program to use: Please choose the name of the "xinit" program to use with nodm. That name will be stored in the NODM_XINIT variable in the command line used by nodm to start the X session: . $NODM_XINIT $NODM_XSESSION -- $NODM_X_OPTIONS Template: nodm/xsession Type: string Default: /etc/X11/Xsession #flag:translate!:3 _Description: X session to use: Please choose the name of the X session script to use with nodm. That name will be stored in the NODM_XSESSION variable in the command line used by nodm to start the X session: . $NODM_XINIT $NODM_XSESSION -- $NODM_X_OPTIONS
--- nodm.old/debian/nodm.templates 2009-03-30 08:43:14.772543104 +0200
+++ nodm/debian/nodm.templates 2009-04-04 08:17:17.775986571 +0200
@@ -2,23 +2,29 @@
Type: boolean
Default: false
_Description: Start nodm on boot?
- nodm starts an X session for a user without asking for authentication. While
- this is welcome for embedded or kiosks systems, it is a security problem in
- most other machines, so by default nodm is configured not to start.
+ Designed for embedded or kiosks systems, nodm starts an X session
+ for a user without asking for authentication. On regular
+ machines, this has security implications and is therefore disabled
+ by default.
.
- If you need autologin on this machine, enable nodm.
+ You should enable nodm only if you need autologin on this machine.
Template: nodm/user
Type: string
Default: root
_Description: User to start a session for:
- Name of the user that will automatically be logged into X by nodm.
+ Please enter the login name of the user that will automatically be logged into X by nodm.
Template: nodm/x_options
Type: string
Default: vt7 -nolisten tcp
+#flag:translate!:3
_Description: Options for the X server:
- Options to pass to the X server when starting the session.
+ Please enter the options to pass to the X server when starting the session.
+ These options will be used in the NODM_X_OPTIONS variable in the command line used
+ by nodm to start the X session:
+ .
+ $NODM_XINIT $NODM_XSESSION -- $NODM_X_OPTIONS
Template: nodm/min_session_time
Type: string
@@ -31,18 +37,22 @@
Template: nodm/xinit
Type: string
Default: /usr/bin/xinit
+#flag:translate!:3
_Description: xinit program to use:
- You can change this to use a different xinit program.
+ Please choose the name of the "xinit" program to use with nodm. That
+ name will be stored in the NODM_XINIT variable in the command line used
+ by nodm to start the X session:
.
- nodm will start the X session with the command:
$NODM_XINIT $NODM_XSESSION -- $NODM_X_OPTIONS
Template: nodm/xsession
Type: string
Default: /etc/X11/Xsession
+#flag:translate!:3
_Description: X session to use:
- You can change this to use a different X session script.
+ Please choose the name of the X session script to use with nodm. That
+ name will be stored in the NODM_XSESSION variable in the command line used
+ by nodm to start the X session:
.
- nodm will start the X session with the command:
$NODM_XINIT $NODM_XSESSION -- $NODM_X_OPTIONS
--- nodm.old/debian/control 2009-03-30 08:43:14.841226598 +0200
+++ nodm/debian/control 2009-04-04 08:17:47.487986804 +0200
@@ -12,11 +12,11 @@
Architecture: any
Depends: xinit, x11-common, xterm | x-terminal-emulator, ${shlibs:Depends}, ${misc:Depends}
Conflicts: gdm, xdm, kdm, x-display-manager, zhone-session
-Description: Automatic Display Manager
+Description: automatic display manager
This packages prepares the system to automatically start an X session at
system boot. It is targeted for devices like smartphones, but can be used
a regular computer as well, if the security implications are acceptable.
.
- It should not be installed on a regular Debian system, as it would interfere
+ It should not be installed on a regular system, as it would interfere
with an installed display manager.
Source: nodm
Section: misc
Priority: extra
Maintainer: Joachim Breitner <nomeata@debian.org>
Uploaders: Enrico Zini <enrico@debian.org>
Build-Depends: debhelper (>= 7), po-debconf, libpam0g-dev, help2man
Standards-Version: 3.8.0
Vcs-Git: http://git.debian.org/git/pkg-fso/nodm.git
Vcs-Browser: http://git.debian.org/?p=pkg-fso/nodm.git;a=summary
Package: nodm
Architecture: any
Depends: xinit, x11-common, xterm | x-terminal-emulator, ${shlibs:Depends}, ${misc:Depends}
Conflicts: gdm, xdm, kdm, x-display-manager, zhone-session
Description: automatic display manager
This packages prepares the system to automatically start an X session at
system boot. It is targeted for devices like smartphones, but can be used
a regular computer as well, if the security implications are acceptable.
.
It should not be installed on a regular system, as it would interfere
with an installed display manager.
Attachment:
signature.asc
Description: Digital signature