Please find, for review, the debconf templates and packages descriptions for the mimedefang source package.
This review will last from Tuesday, January 01, 2008 to Friday, January 11, 2008.
Please send reviews as unified diffs (diff -u) against the original
files. Comments about your proposed changes will be appreciated.
Your review should be sent as an answer to this mail.
When appropriate, I will send intermediate requests for review, with
"[RFRn]" (n>=2) as a subject tag.
When we will reach a consensus, I send a "Last Chance For
Comments" mail with "[LCFC]" as a subject tag.
Finally, the reviewed templates will be sent to the package maintainer
as a bug report, and a mail will be sent to this list with "[BTS]" as
a subject tag.
Rationale:
--- ../mimedefang.old/debian/templates 2007-12-11 09:40:06.712314288 +0100
+++ debian/templates 2007-12-14 18:34:20.595534337 +0100
@@ -2,5 +2,5 @@
Type: boolean
Default: true
_Description: Should MIMEDefang use the embedded Perl interpreter?
- Choosing this option will significantly improve performance. However
- some systems do not support it. If in doubt, you can select this option.
+ Choosing this option is generally safe and will significantly improve
+ performance. However some systems do not support it.
Avoid repetition and simplify the paragraph.
--- ../mimedefang.old/debian/control 2007-12-11 09:40:06.712314288 +0100
+++ debian/control 2007-12-20 06:42:48.481294614 +0100
@@ -10,21 +10,19 @@
Depends: ${shlibs:Depends}, ${perl:Depends}, debconf (>= 0.5) | debconf-2.0, libmime-perl, libio-stringy-perl, libmime-base64-perl, libmailtools-perl, libdigest-sha1-perl, libunix-syslog-perl, psmisc, adduser
Recommends: tk8.3 | wish, sendmail
Suggests: libmail-spamassassin-perl, sanitizer, libhtml-parser-perl, wv, libfile-scan-perl, clamav, libarchive-zip-perl, graphdefang
-Description: Electronic mail filter program for sendmail 8.12+
- MIMEDefang is an e-mail filter program which works with Sendmail 8.12
- and later. MIMEDefang filters all e-mail messages sent via SMTP.
- MIMEDefang splits multi-part MIME messages into their components and
- potentially deletes or modifies the various parts. It then
- reassembles the parts back into an e-mail message and sends it on its
- way.
+Description: e-mail filter program for sendmail
I'm not sure whether we've settled on "email" vs "e-mail"....
Anyway:
-avoid leading capital
-do not mention the sendmail's version
+ MIMEDefang is an e-mail filter program which processes all messages sent
+ via Sendmail. It splits multi-part MIME messages into their components
+ and can delete or modify those parts before reassembling the message and
+ sending it on its way.
Avoid repeating the program's name all over. Also, no mention of the
version of sendmail
Package: graphdefang
Architecture: any
Depends: ${perl:Depends}, libfile-readbackwards-perl, libgd-graph-perl, libgd-text-perl (>= 0.86-1), libtimedate-perl, libmldbm-perl, perl (>= 5.8.3) | libstorable-perl
Recommends: php5
Suggests: mimedefang
-Description: create graphs of your mimedefang spam and virus logs
- GraphDefang is a configurable perl utility that parses arbitrary
- syslog entries and creates a set of configurable charts (png files)
- with the data. It is possible to output the png files to the
- filesystem or to a web browser via a cgi.
+Description: create graphs from MIMEDefang's spam and virus logs
+ GraphDefang is a configurable utility that parses arbitrary
+ syslog entries and creates a set of configurable charts (PNG files)
+ with the data. These files can be written on disk or displayed by a
+ web server through a CGI interface.
There is not much value added to mention this is Perl or whatever else.
s/png/PNG
Style changes to have a better flow in the wording (imho..:-))
"a cgi" has no meaning --> "CGI interface" sounds better.
--
Template: mimedefang/embedperl Type: boolean Default: true _Description: Should MIMEDefang use the embedded Perl interpreter? Choosing this option is generally safe and will significantly improve performance. However some systems do not support it.
--- mimedefang.old/debian/templates 2007-12-11 09:40:06.712314288 +0100
+++ mimedefang/debian/templates 2007-12-14 18:34:20.595534337 +0100
@@ -2,5 +2,5 @@
Type: boolean
Default: true
_Description: Should MIMEDefang use the embedded Perl interpreter?
- Choosing this option will significantly improve performance. However
- some systems do not support it. If in doubt, you can select this option.
+ Choosing this option is generally safe and will significantly improve
+ performance. However some systems do not support it.
--- mimedefang.old/debian/control 2007-12-11 09:40:06.712314288 +0100
+++ mimedefang/debian/control 2008-01-01 13:10:17.651279806 +0100
@@ -10,21 +10,19 @@
Depends: ${shlibs:Depends}, ${perl:Depends}, debconf (>= 0.5) | debconf-2.0, libmime-perl, libio-stringy-perl, libmime-base64-perl, libmailtools-perl, libdigest-sha1-perl, libunix-syslog-perl, psmisc, adduser
Recommends: tk8.3 | wish, sendmail
Suggests: libmail-spamassassin-perl, sanitizer, libhtml-parser-perl, wv, libfile-scan-perl, clamav, libarchive-zip-perl, graphdefang
-Description: Electronic mail filter program for sendmail 8.12+
- MIMEDefang is an e-mail filter program which works with Sendmail 8.12
- and later. MIMEDefang filters all e-mail messages sent via SMTP.
- MIMEDefang splits multi-part MIME messages into their components and
- potentially deletes or modifies the various parts. It then
- reassembles the parts back into an e-mail message and sends it on its
- way.
+Description: e-mail filter program for sendmail
+ MIMEDefang is an e-mail filter program which processes all messages sent
+ via Sendmail. It splits multi-part MIME messages into their components
+ and can delete or modify those parts before reassembling the message and
+ sending it on its way.
Package: graphdefang
Architecture: any
Depends: ${perl:Depends}, libfile-readbackwards-perl, libgd-graph-perl, libgd-text-perl (>= 0.86-1), libtimedate-perl, libmldbm-perl, perl (>= 5.8.3) | libstorable-perl
Recommends: php5
Suggests: mimedefang
-Description: create graphs of your mimedefang spam and virus logs
- GraphDefang is a configurable perl utility that parses arbitrary
- syslog entries and creates a set of configurable charts (png files)
- with the data. It is possible to output the png files to the
- filesystem or to a web browser via a cgi.
+Description: create graphs from MIMEDefang's spam and virus logs
+ GraphDefang is a configurable utility that parses arbitrary
+ syslog entries and creates a set of configurable charts (PNG files)
+ with the data. These files can be written on disk or displayed by a
+ web server through a CGI interface.
Source: mimedefang
Section: mail
Priority: extra
Maintainer: Christoph Martin <christoph.martin@uni-mainz.de>
Build-Depends: debhelper (>= 5), libmilter-dev, mailx, libunix-syslog-perl, libperl-dev, libmime-perl, libdigest-sha1-perl, libmail-spamassassin-perl, sanitizer, libhtml-parser-perl, libfile-scan-perl, libarchive-zip-perl
Standards-Version: 3.6.1
Package: mimedefang
Architecture: any
Depends: ${shlibs:Depends}, ${perl:Depends}, debconf (>= 0.5) | debconf-2.0, libmime-perl, libio-stringy-perl, libmime-base64-perl, libmailtools-perl, libdigest-sha1-perl, libunix-syslog-perl, psmisc, adduser
Recommends: tk8.3 | wish, sendmail
Suggests: libmail-spamassassin-perl, sanitizer, libhtml-parser-perl, wv, libfile-scan-perl, clamav, libarchive-zip-perl, graphdefang
Description: e-mail filter program for sendmail
MIMEDefang is an e-mail filter program which processes all messages sent
via Sendmail. It splits multi-part MIME messages into their components
and can delete or modify those parts before reassembling the message and
sending it on its way.
Package: graphdefang
Architecture: any
Depends: ${perl:Depends}, libfile-readbackwards-perl, libgd-graph-perl, libgd-text-perl (>= 0.86-1), libtimedate-perl, libmldbm-perl, perl (>= 5.8.3) | libstorable-perl
Recommends: php5
Suggests: mimedefang
Description: create graphs from MIMEDefang's spam and virus logs
GraphDefang is a configurable utility that parses arbitrary
syslog entries and creates a set of configurable charts (PNG files)
with the data. These files can be written on disk or displayed by a
web server through a CGI interface.
Attachment:
signature.asc
Description: Digital signature