Bug#597820: linux-image-2.6.32-5-amd64: 2.6.32 doesn't support the f71889fg sensor chip
On Sun, Oct 03, 2010 at 02:02:32PM +0200, Giel van Schijndel wrote:
> On Sun, Oct 03, 2010 at 09:14:44AM +0200, Mike Hommey wrote:
> > On Sun, Oct 03, 2010 at 01:14:24AM +0200, Giel van Schijndel wrote:
> >> On Sat, Oct 02, 2010 at 08:42:19PM +0100, Ben Hutchings wrote:
> >>> On Tue, 2010-09-28 at 10:36 +0200, Mike Hommey wrote:
> >>>> I would also be interested in the watchdog support for the same
> >>>> chip,
> >>
> >> That patch does *not* add watchdog support for the Fintek F71889FG
> >> chip, it *only* adds support for the F71808E and the F71882FG.
> >
> > Oops.
> >
> >> Additionally a patch for the F71862FG is currently pending review and
> >> inclusion.
> >>
> >> That being said, this driver should be fairly easy to expand to
> >> include support for the F71889FG chip (AFAIK only pin-configuration
> >> should be added, which probably is just a datasheet-reading
> >> exercise). Adding support however would be something I'd suggest
> >> doing across the LKML *first*, then (optionally) backport it later.
> >>
> >>> However, the last patch (729d273aa7c86eb1406ade4eadf249cff188bf9a)
> >>> doesn't look right; surely it should be using the new
> >>> request_muxed_region() macro too?
> >>
> >> IIRC that patch was submitted and applied *before* 8b6d043, hence
> >> request_muxed_region() wasn't available and thus not used.
> >>
> >> The patch to make use of request_muxed_region() [1] has been acked [2]
> >> but not yet applied yet, I've just sent out a poke-mail (CC-ed to this
> >> bug) with the request for it to be committed.
> >>
> >> [1] <1280669455-31283-1-git-send-email-me@mortis.eu>
> >
> > AFAICS, this id refers to the patch that ended in
> > 96cb4eb019ce3185ec0d946a74b5a2202f5067c9.
>
> I can't find that commit in Torvald's tree. Who's the author and what's
> the first line of the commit message?
commit 96cb4eb019ce3185ec0d946a74b5a2202f5067c9
Author: Giel van Schijndel <me@mortis.eu>
Date: Sun Aug 1 15:30:55 2010 +0200
watchdog: f71808e_wdt: new watchdog driver for Fintek F71808E and F71882FG
In Linus' tree.
$ git describe --contains 96cb4eb019ce3185ec0d946a74b5a2202f5067c9
v2.6.36-rc1~290^2~2
> > The one you are referring to must be
> > http://marc.info/?l=lm-sensors&m=127219192018988&w=2
>
> Actually I'm referring to this patch (updated/rebased version of the one
> you're referring to):
> http://marc.info/?l=linux-kernel&m=128066949410960&w=2
>
> PS marc.info allows direct searching on Message-ID like so:
> http://marc.info/?i=$message_id
> e.g.:
> http://marc.info/?i=1280669455-31283-1-git-send-email-me@mortis.eu
Interestingly, I found this with your message-id:
https://patchwork.kernel.org/patch/116315/
Mike
Reply to: