Andrew Morton wrote:
Jeff Garzik <jgarzik@pobox.com> wrote:Luis, you, or somebody should create a new patch series with just the critical fixes, NO WHITESPACE/FORMATTING CHANGES mixed in, and send those first.Whitespace changes are often nice, but they should be the very first patch[es] in the series. You should be able to verify that the .o file was unchanged before and after.
Very first, or very last. I leave that up to the maintainer.
That way they become a no-brainer and it becomes easier to review and understand the substantive changes.
Agreed.Further, when someone mixes an Lindent in with functional changes, I become very suspicious. That is precisely the method that certain high profile Linux hackers have used in the past to intentionally obfuscate security changes.
Jeff