Hi,
Alle mercoledì 28 dicembre 2011, Svante Signell ha scritto:
> -int sc_get_cache_dir(sc_context_t *ctx, char *buf, size_t bufsize)
> +int sc_get_cache_dir(sc_context_t *ctx, char *buf)
'buf' should be 'char**' (with the code assigning to '*buf'), otherwise
you're just changing the value of a local variable inside the function
> static int generate_cache_filename(struct sc_pkcs15_card *p15card,
> const sc_path_t *path,
> - char *buf, size_t bufsize)
> + char *buf)
same as above
> static int
> -get_profile_from_config(struct sc_card *card, char *buffer, size_t
> size)
> +get_profile_from_config(struct sc_card *card, char *buffer) {
same as above
> -int sc_get_cache_dir(sc_context_t *ctx, char *buf, size_t bufsize);
> +int sc_get_cache_dir(sc_context_t *ctx, char *buf);
other than the problem above, this looks like a public function (as also
the .exports file confirms) of a public library, so changing its
signature is an API and ABI break; this needs to be discussed upstream
directly
--
Pino Toscano
Attachment:
signature.asc
Description: This is a digitally signed message part.