[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: gnurobbo



Hi,

Vincent Bernat wrote:
> OoO  En cette  nuit striée  d'éclairs du  dimanche 27  avril  2008, vers
> 02:06, Ansgar Burchardt <ansgar@2008.43-1.org> disait:
> 
> > Lintian v1.23.46 complains about files generated by configure in the
> > upstream tarball (config.log, config.status).  I added an override, because
> > they will be regenerated (and later removed by the clean target).
> 
> There is also a precompiled version of gnurobbo executable. I don't know
> if such  a tarball should  be repacked or  not. For such a  small binary
> (117K), I think that repacking is not needed.

I was not sure about repacking as well, but I too think it isn't necessary.
The package was already repackaged once, because it did contain a non-free
font (that's also the reason that the current version is not available
upstream).

> You may  want to add a debian/watch  file, even if upstream  seems to be
> dead.

Done.

> You can drop this snippet from debian/rules:
>  ifneq (,$(findstring noopt,$(DEB_BUILD_OPTIONS)))
>  	CFLAGS += -O0
>  else
>  	CFLAGS += -O2
>  endif
> 
> This is already done by dpkg-buildpackage.

Done, and uploaded the new version to mentors.  It's still available with
dget http://mentors.debian.net/debian/pool/main/g/gnurobbo/gnurobbo_0.57.1-2.dsc

> Otherwise, you did a great job  at cleaning up this package. Has someone
> From Debian Games team already proposed to sponsor this upload?

No, not yet.

Regards,
Ansgar

-- 
pgp: 0xF1F477C0    2BE4 CE2A E9CB 27D3 29F4  502E 53B1 6D9C F1F4 77C0

Attachment: signature.asc
Description: Digital signature


Reply to: