Re: Bug#630206: libnss-myhostname: FTBFS: fatal error: asm/types.h: No such file or directory
On Mon, 13.06.11 14:13, Robert Millan (firstname.lastname@example.org) wrote:
> tags 630206 patch
> 2011/6/13 Robert Millan <email@example.com>:
> > 2011/6/13 Lennart Poettering <firstname.lastname@example.org>:
> >> I think it is a major waste of time thinking about BSD and Hurd.
> >> That said, I'd be willing to merge a patch that adds support for those
> >> legacy systems -- if it is minimal. Note however that it wouldn't be
> >> release critical to me, i.e. I will not care if it works or not when
> >> releasing a new version. But I geuss that doesn't matter much since it
> >> is quite a finished project and I expect very few updates in the future.
> > Seems simple enough, I'll give it a try.
> Patch attached. To be applied after "mv netlink.h ifconf.h".
Sounds mostly good. Can you prep a proper git patch please?
> diff -Nur -x aclocal.m4 -x configure -x doc libnss-myhostname-0.3/ifconf.c libnss-myhostname-0.3.new/ifconf.c
> --- libnss-myhostname-0.3/ifconf.c 1970-01-01 01:00:00.000000000 +0100
> +++ libnss-myhostname-0.3.new/ifconf.c 2011-06-13 14:06:34.000000000 +0200
> @@ -0,0 +1,5 @@
> +#ifdef __linux__
> +#include "netlink.c"
> +#include "legacy.c"
Urks, no. Please do this in Makefile.am.
> diff -Nur -x aclocal.m4 -x configure -x doc libnss-myhostname-0.3/ifconf.h libnss-myhostname-0.3.new/ifconf.h
> --- libnss-myhostname-0.3/ifconf.h 2011-05-09 15:00:58.000000000 +0200
> +++ libnss-myhostname-0.3.new/ifconf.h 2011-06-13 14:01:28.000000000 +0200
> @@ -3,6 +3,8 @@
> #ifndef foonetlinkhfoo
> #define foonetlinkhfoo
Please fix the header here.
> + fd = socket (AF_INET6, SOCK_DGRAM, 0);
Please follow the coding style, we do not place a space between the
function name and the opening bracket.
Also, this will obviously fail if IPv6 is not enabled. I personally
don't care about that, but I am pretty sure the same kids who care about
Hurd also care about IPv6-free systems. It's up to you if you want to
fix this. I'd merge it either way.
This gets particularly strange given that SIOCGIFCONF according to the
(Linux) man page only returns IPv4 addresses.
Lennart Poettering - Red Hat, Inc.