Re: Bug#587588: build on kfreebsd
On Wed, 2010-06-30 at 09:46:34 +0200, Cyril Brulebois wrote:
> Tuco <email@example.com> (30/06/2010):
> > Package: pwlib
> > Version: 1.10.10-3
> > Severity: serious
> > This patch fixes build problems of pwlib on kfreebsd.
Hmmm, I doubt this specific incarnation does build, see below.
> Thanks for that.
> Some comments:
> - it'd be nice to tag the bug as having a patch.
Personally, I only tag bugs which have patches that can be applied
directly by the maintainer.
This one has bogus changes in the Architecture fields.
It also completely stops installing several Linux specific plugins,
they should be conditionally installed only on Linux, checking
DEB_HOST_ARCH_OS from dpkg-architecture.
The termios.h change should probably be changed to a file availability
check in configure.in (or this might break the Solaris build).
And finally, OSTYPE in upstream is a bit confused, it refers to kernel
features and also to libc features which would be better represented
with something like “GNU” in our case, although ideally those would be
switched to feature checks so that new systems could probably work out
of the box.