[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#586687: marked as done (debian-installer: build scripts can use outdated packages)

Your message dated Sun, 1 Aug 2010 17:20:21 +0200
with message-id <20100801152021.GA18052@const.famille.thibault.fr>
and subject line Re: debian-installer: build scripts can use outdated packages
has caused the Debian Bug report #586687,
regarding debian-installer: build scripts can use outdated packages
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
586687: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=586687
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: debian-installer
Severity: normal
Tags: patch
Usertags: gsoc2010

Hello,

(my earlier email to debian-boot did not attract any comment, I'm
resubmitting this as a bug so as to document and keep track of it)

The get-packages script from installer/build/util/ uses "sort | tail -1"
to get the most recent version of a given udeb from apt.udeb/cache.
This may cause images to be built with outdated udebs.

The attached patch makes it use 'dpkg --compare-versions' instead.

Thanks,
-- 
Jeremie Koenig <jk@jk.fr.eu.org>
http://jk.fr.eu.org

Index: debian/changelog
===================================================================
--- debian/changelog	(revision 63446)
+++ debian/changelog	(working copy)
@@ -69,8 +69,11 @@
   [ Otavio Salvador ]
   * Move hppa, ia64, powerpc and s390 to linux 2.6.32 (ABI 5).
 
- -- Christian Perrier <bubulle@debian.org>  Sun, 14 Feb 2010 17:06:27 +0100
+  [ Jeremie Koenig ]
+  * util/get-packages: fix selection of the most recent packages.
 
+ -- Jeremie Koenig <jk@jk.fr.eu.org>  Thu, 17 Jun 2010 17:01:14 +0200
+
 debian-installer (20100211) unstable; urgency=low
 
   [ Frans Pop ]
Index: build/util/get-packages
===================================================================
--- build/util/get-packages	(revision 63446)
+++ build/util/get-packages	(working copy)
@@ -186,7 +186,13 @@
 
 lnpkg() {
 	local pkg=$1; local dir=$2 debdir=$3
-	local L="`find $dir -name "${pkg}_*" 2>/dev/null | sort | tail -n 1`"
+	local L LV l lv
+	for l in `find $dir -name "${pkg}_*" 2>/dev/null`; do
+		lv=${l%_*}; lv=${lv##*_};
+		if dpkg --compare-versions "$lv" gt "$LV"; then
+			L=$l LV=$lv
+		fi
+	done
 	if [ -e "$L" ]; then
 		ln -f $L $debdir/$pkg.$TYPE
 	fi

--- End Message ---
--- Begin Message --- 
Version: 20100719

Patch got commited some time ago already.

--- End Message ---
Reply to: