[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: r61385 - in trunk/packages/choose-mirror: . debian



On Friday 20 November 2009, Jérémy Bobbio wrote:
> > +	/* Arrays can never overflow as we've already checked releases */
> > +	for (i=0; releases[i].name != NULL; i++) {
> > +		char *name;
>
> name is not modified, so 'const char * name' would be better.

That results in a compilation warning, so I've kept it as is:
warning: assignment discards qualifiers from pointer target type

All other comments done. Thanks again Jérémy.


Reply to: